Optimize Vec::push#39
Merged
Merged
Conversation
ibraheemdev
commented
Aug 13, 2025
|
|
||
| // If we are close to the end of this bucket, we eagerly allocate the next one to reduce | ||
| // later contention. | ||
| if location.entry == location.bucket_len.get() / 8 * 7 { |
Owner
Author
There was a problem hiding this comment.
@SabrinaJewson is there a reason you changed the math here? This seems to result in an extra instruction, on x86 at least.
Contributor
There was a problem hiding this comment.
That aws an oversight on my part, sorry 😅. Was just rewriting it to my understanding of what the code did, but didn’t check if that understanding was correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This significantly improves the codegen of
Vec::push.