Skip to content

Allow windows-sys up to 0.61, and use cargo-minimal-versions to validate#42

Merged
ibraheemdev merged 3 commits into
ibraheemdev:masterfrom
dpaoliello:windowssys
Sep 13, 2025
Merged

Allow windows-sys up to 0.61, and use cargo-minimal-versions to validate#42
ibraheemdev merged 3 commits into
ibraheemdev:masterfrom
dpaoliello:windowssys

Conversation

@dpaoliello

@dpaoliello dpaoliello commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

windows-sys didn't make any breaking changes in 0.60 or 0.61 that affect seize, so permit all versions from 0.59-0.61 to be used.

This change also adds tests via cargo-minimal-versions to ensure that the crate still works correctly with minimal versions of its dependencies.

Also had to bump criterion to 0.3.6 from 0.3.5, otherwise minimal-versions would pull in two versions of winapi, which then causes issues.

@ibraheemdev

Copy link
Copy Markdown
Owner

Thanks for the PR. I would prefer to update to 0.61 directly, I don't see a need to maintain compatibility with older versions, given that it's an internal dependency.

@dpaoliello

Copy link
Copy Markdown
Contributor Author

given that it's an internal dependency

I'm not sure what you mean: this isn't a dev-dependency, so anyone relying on seize will be forced to 0.61 even if they have 0.59 or 0.60 already in their graph.

@ibraheemdev

Copy link
Copy Markdown
Owner

I mean that it's not part of the public facing API. I suppose it's fine to maintain compatibility with older versions as long as we test against them in CI. Thanks!

@ibraheemdev ibraheemdev merged commit 9b2fade into ibraheemdev:master Sep 13, 2025
13 checks passed
@ibraheemdev ibraheemdev mentioned this pull request Sep 13, 2025
@dpaoliello dpaoliello deleted the windowssys branch September 15, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants