Allow windows-sys up to 0.61, and use cargo-minimal-versions to validate#42
Merged
Merged
Conversation
Owner
|
Thanks for the PR. I would prefer to update to 0.61 directly, I don't see a need to maintain compatibility with older versions, given that it's an internal dependency. |
Contributor
Author
I'm not sure what you mean: this isn't a |
ba9d19f to
7db1786
Compare
Owner
|
I mean that it's not part of the public facing API. I suppose it's fine to maintain compatibility with older versions as long as we test against them in CI. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-sysdidn't make any breaking changes in 0.60 or 0.61 that affectseize, so permit all versions from 0.59-0.61 to be used.This change also adds tests via
cargo-minimal-versionsto ensure that the crate still works correctly with minimal versions of its dependencies.Also had to bump
criterionto 0.3.6 from 0.3.5, otherwise minimal-versions would pull in two versions ofwinapi, which then causes issues.