Add warning when combining RDBESDataObjects from different hierarchies#249
Merged
Add warning when combining RDBESDataObjects from different hierarchies#249
Conversation
Co-authored-by: rix133 <6965560+rix133@users.noreply.github.com>
Co-authored-by: rix133 <6965560+rix133@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update combineRDBESDataObjects for multiple hierarchy handling
Add warning when combining RDBESDataObjects from different hierarchies
Oct 15, 2025
rix133
requested changes
Oct 15, 2025
Contributor
rix133
left a comment
There was a problem hiding this comment.
there should be stop instead of warning if strict is TRUE ie it warns if not strict and stops if strict about the hieararchy mismatch
Only when main updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
combineRDBESDataObjectsfunction can now be used to combine data from different hierarchies (e.g., H1 and H5), but previously did so silently, leading to structurally and statistically invalid objects. This PR adds an explicit warning to inform users when they are combining objects from different hierarchies.Changes
Functionality
DEhierarchyvalues from both input objectsWarning Message
When combining different hierarchies, users now see:
Documentation
@detailssection explaining when warnings are issuedTests
Design Rationale
Following feedback from @rix133, this implementation:
print.RDBESDataObjectwarning for mixed hierarchies)strictparameter to ensure users are always informedUse Cases
This change is particularly useful for:
Users can now combine objects from different hierarchies with clear understanding of the implications.
Closes #[issue_number]
Original prompt
Fixes #242
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.