check code diff between old and new repo (don't merge)#7
Open
Abdalla1423 wants to merge 1 commit intomainfrom
Open
check code diff between old and new repo (don't merge)#7Abdalla1423 wants to merge 1 commit intomainfrom
Abdalla1423 wants to merge 1 commit intomainfrom
Conversation
Abdalla1423
commented
May 11, 2025
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
what is this for?
Abdalla1423
commented
May 11, 2025
| result_path = Path(ilp_problem=ilp_problem, nodes=candidate_path_nodes) | ||
|
|
||
| # feasibility test | ||
| value = self.measure_path(result_path, f'gen-basis-path-row{current_row}-attempt{i}') |
Collaborator
Author
There was a problem hiding this comment.
- feasability test through measurement
Abdalla1423
commented
May 11, 2025
| current_row += 1 | ||
| num_paths_unsat = 0 | ||
|
|
||
| #feasibility test |
Collaborator
Author
There was a problem hiding this comment.
- again checking feasibility through measurement
Collaborator
Author
There was a problem hiding this comment.
SMT hidden in the function
Abdalla1423
commented
May 11, 2025
| logger.info("Adding a constraint to exclude these edges...") | ||
| infeasible.append(candidate_path_edges) | ||
|
|
||
| logger.info("Finding the edges to exclude...") |
Collaborator
Author
There was a problem hiding this comment.
There is some logic missing
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
- Replace CIL prepocessing with Clang preprocessing
- Rename variables
- move helper functions for file processing
- feasibility check through measurement
- some logic is missing
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
replaced with llvm
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
replaced cil and phoenix
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
replaced with yaml
Abdalla1423
commented
May 11, 2025
Abdalla1423
commented
May 11, 2025
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
replace cil with llvm
Abdalla1423
commented
May 11, 2025
| logger.info("Candidate path found.") | ||
| logger.info("Running the candidate path to check feasibility and measure run time") | ||
| candidate_path_edges = Dag.get_edges(candidate_path_nodes) | ||
| candidate_path_value = ilp_problem.obj_val |
Collaborator
Author
There was a problem hiding this comment.
check feasibility using new smt
Abdalla1423
commented
May 11, 2025
| elif querySatisfiability == Satisfiability.UNSAT: | ||
| logger.info("Candidate path is infeasible.") | ||
| analyzer.add_path_exclusive_constraint(candidate_path_edges) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
logic missing?
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
replaced by llvm
Abdalla1423
commented
May 11, 2025
Abdalla1423
commented
May 11, 2025
Abdalla1423
commented
May 11, 2025
Collaborator
Author
There was a problem hiding this comment.
gametime versioning
Abdalla1423
commented
May 11, 2025
Abdalla1423
commented
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.