Simplify hash type name getters - #185
Merged
Merged
Conversation
Replace PyUnicode_FromStringAndSize(name, strlen(name)) with PyUnicode_FromString(name) in the four get_name implementations, and drop the now-unused <string.h> include.
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the four
get_nameimplementations and drop a now-unused include.Changes
src/_xxhash.c: usePyUnicode_FromString(name)instead ofPyUnicode_FromStringAndSize(name, strlen(name))in thexxh32/xxh64/xxh3_64/xxh3_128name getters#include <string.h>that only served thosestrlencalls4.0.0.dev7Testing
XXH32,XXH64,XXH3_64,XXH3_128)