Unify lock allocation and GIL release thresholds - #186
Merged
Conversation
XXHASH_LOCK_MAYBE_INIT allocated the lock at >= XXHASH_GIL_MINSIZE while every GIL release check uses >, so an update of exactly 64KB allocated a lock that was never used. Align both at > XXHASH_GIL_MINSIZE and update the README wording.
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the lazy lock allocation threshold with the GIL release threshold in
_xxhash.c.Changes
src/_xxhash.c:XXHASH_LOCK_MAYBE_INITallocated the lock at>= XXHASH_GIL_MINSIZEwhile every GIL release check uses>, so an update of exactly 64KB allocated a lock that was never used. Both now use> XXHASH_GIL_MINSIZEREADME.rst: update the thread-safety wording to match ("more than 64KB", "operations of 64KB or less")4.0.0.dev8Testing