Adds dockerized development environment#123
Adds dockerized development environment#123alaxalves wants to merge 8 commits intoigdmapps:masterfrom
Conversation
|
Any doubts or suggestions I'm here to help. |
|
@alaxalves wow thank you for the PR, I'll review and let you know |
ifedapoolarewaju
left a comment
ifedapoolarewaju
left a comment
There was a problem hiding this comment.
Hi @alaxalves, sorry the review came a bit lit, but I added a few notes. Please let me know what you think.
README.md
Outdated
|
|
||
| 4. Download Nut by running `curl -L https://github.com/matthieudelaro/nut/raw/manualbuild/release/linux/nut -o nut && chmod a+x nut` | ||
|
|
||
| 4. Run `sudo mv nut /usr/local/bin/nut` to move the nut executable to you local binaries *optional step* |
There was a problem hiding this comment.
typo here "you" -> "your" 🙂
nut.yml
Outdated
| actions: | ||
| - npm install | ||
| - npm run build | ||
| - npm run gui |
There was a problem hiding this comment.
why not just npm start, Which runs both gulp build && electron .?
There was a problem hiding this comment.
npm start would fit here as well. Do you want me to change??
package.json
Outdated
| "main": "main/main.js", | ||
| "scripts": { | ||
| "build": "gulp build", | ||
| "gui": "electron .", |
There was a problem hiding this comment.
I'm not sure we need these scripts, especially if you agree with my suggestion above
There was a problem hiding this comment.
I needed to split those commands because I added the option to nut reload in the nut.yml file. This option allows you to build your code again and see the changes you have made in the software without having to drop the docker containers. Otherwise you'd have to re-run the docker container everytime you made a change and wanted it to make effect.
|
me sale "Cookie |
… gui` As requested in igdmapps#123 Signed-off-by: Alax Alves <alaxallves@gmail.com>
As requested in igdmapps#123 Signed-off-by: Alax Alves <alaxallves@gmail.com>
| run: | ||
| actions: | ||
| - npm install | ||
| - npm start |
There was a problem hiding this comment.
@ifedapoolarewaju Hey I've changed the code according to the request you've made!
|
I can't find the chats help me |
ifedapoolarewaju
force-pushed
the
master
branch
from
0af00b4 to
40621cf
Compare
ifedapoolarewaju
force-pushed
the
master
branch
5 times, most recently
from
3f2ddfb to
6b32139
Compare
ifedapoolarewaju
force-pushed
the
master
branch
5 times, most recently
from
a4d5c95 to
59fcfa3
Compare
ifedapoolarewaju
force-pushed
the
master
branch
4 times, most recently
from
c614180 to
f09f454
Compare
4 participants
This PR proposes an entire wrapped development environment, making easier to collaborate.