Open
Conversation
We will use Intern as a testing framework because it seamlessly integrates with chai for running tests, as well as vast testing capabilities and onboard TypeScript support. The sample.js contains a simple test that should integrate with TravisCI and will be deleted when tests are implemented.
Whoops, I forgot to add the object descriptor..
This completes the basic setup and makes it possible to: - run tests using the intern testrunner (npm test) - mock dependencies using testdouble Note: Electron can't be mocked by td itself, so providing a manual mock is needed. This should be modularized in the future.
ifedapoolarewaju
force-pushed
the
master
branch
from
0af00b4 to
40621cf
Compare
Collaborator
|
Hi, I just wanted to say thank you for your work on this! Is this good for me to do a full review yet, or are you still working on it? I have taken a glance, but not a thorough review. |
Author
|
You can take a review if you want. The basic setup is complete, so all that's left to add are the actual tests. A review on the structure or syntax you prefer would actually help me out a lot as well since I can keep it in line with the rest of the project. |
Collaborator
|
Hi @curtisy1 wanted to check in on the status of this PR? :) |
ifedapoolarewaju
force-pushed
the
master
branch
5 times, most recently
from
3f2ddfb to
6b32139
Compare
ifedapoolarewaju
force-pushed
the
master
branch
9 times, most recently
from
c614180 to
f09f454
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress proposed fix to #19. I'll gradually add more tests but the foundation is there for now. As a quick overview of what I decided on using and how this all works, here's a small writeup:
The testing framework used is Intern. This allows using chai asserts which are easier to read in my opinion. As well as a close to zero configuration setup which lets us focus on writing tests instead of configuring things that aren't really necessary.
Furthermore, because we can't use electron or node_modules directly. We rely on testdouble which allows us to mock external dependencies by either: