Adapt to upstream gpf-schema-store v0.2.2 - #179
Open
LionelZoubritzky-IGN wants to merge 31 commits into
Open
Conversation
LionelZoubritzky-IGN
force-pushed
the
142-gpfschemastore0.2.0
branch
from
July 27, 2026 15:17
52ee613 to
12ab11b
Compare
mborne
requested changes
Jul 27, 2026
mborne
left a comment
Collaborator
There was a problem hiding this comment.
Mainly 2 points :
- Handle
dateanddate-timeby checking the format instead of inspecting the name of the property - Use the following fixture for geometry properties in tests :
"properties":{
"geometrie" : {
"x-ogc-role" : "primary-geometry",
"format" : "geometry-multipolygon"
}
}
LionelZoubritzky-IGN
force-pushed
the
142-gpfschemastore0.2.0
branch
2 times, most recently
from
July 28, 2026 09:45
ac71468 to
197080b
Compare
LionelZoubritzky-IGN
force-pushed
the
142-gpfschemastore0.2.0
branch
4 times, most recently
from
July 30, 2026 09:25
afbd2c7 to
83c52f3
Compare
LionelZoubritzky-IGN
force-pushed
the
142-gpfschemastore0.2.0
branch
3 times, most recently
from
August 3, 2026 16:01
09e73cf to
b7d19b1
Compare
Member
|
Uh ... code was peer reviewed but was it actually tested ? 🤔
"properties": {
"type": "string"
},
|
Contributor
Author
|
Now we have a difficulty: the goal of the main change of gpf-schema-store was to use OGC API Features output schemas. Those inherently have a
Barring objections I'll start by implementing 1 because it is by far the simplest option. We can revisit this problem as a separate issue later. |
Contributor
Author
LionelZoubritzky-IGN
force-pushed
the
142-gpfschemastore0.2.0
branch
2 times, most recently
from
August 5, 2026 12:30
91d9c2f to
a6102b0
Compare
esgn
requested changes
Aug 6, 2026
esgn
requested changes
Aug 7, 2026
Co-authored-by: mborne <mborne@users.noreply.github.com>
…tSchema for all tools Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
… DetailedCollectionSearchMatch Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
…t in a collection
…atureType object type
LionelZoubritzky-IGN
force-pushed
the
142-gpfschemastore0.2.0
branch
from
August 12, 2026 09:40
e1f709c to
f791f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Main changes:
getCollectionSchema,search,CollectionSearchMatch).OgcCollectionSchema,OgcCollectionProperty) and adaptedproperty/enumhandling tooneOf.gpf_describe_typeandgpf_search_typesto reflect the new schema model.Close #142