[build] Use fixed versions for jxmpp and minidns#708
Open
stokito wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jxmpp and minidns libraries are declared with a version range. You remember #61 where I first time proposed to fixate the version to make IntelliJ happy.
In the Spark I faced another problem that the minidns was resolved into the lowest version. I had to add the dependency manually and also exclude the minidns from smack transitives because the Maven Enforcer "version convergence" rule failed because two versions of the same library in a dependency tree.
We should avoid using ranges. Instead it must be specified the latest know version of library that works fine with the Smack. If an xmpp clients (e.g. Spark, aTalk) needs to use a different version they can define the dependency explicitly.
Also the version range hided the problem that
org.minidns:minidns-android21should be changed toorg.minidns:minidns-android23.