Closed
Conversation
Add WFM connection class and specs
* add Staff.list * fix model namespace * remove extra line * drop sax parser * remove parser spec * optimise * fix payroll_code * add dry typesa * Revert "add dry typesa" This reverts commit 05de0bc. * superclass errors + add api_url * update to use Connection
Adding VCR spec to Staff List. IGNT-3573
Adding ruby action
Remove gem versions and bundle update (for my gems)
* Adding job.api/current * don't convert to date (leave as string) * test name update * remove API key
* Add Faraday post to connection and post test with VCR * Rubocop fixes
* Switch `get` tests from mocks to VCR * Remove encoded auth * refactor get and post to be more similar and add content type to post * rubocop fix
* add Staff.list * fix model namespace * remove extra line * drop sax parser * remove parser spec * optimise * fix payroll_code * commit unfinished changes * add incomplete spec * initial commit * update spec * commit changes * Add module * add Nokogiri::Xml::Builder * fix require * pass spec * fix cops * update based on Tony's feedback * fix spacing * fix ordering * fix ordering
…(#17) * Refactor connection to use access token and xero_tenant_id * Fix job spec * use access_token for staff * template fix * rubocop fixes * Use new connection settings for client * Rubocop fix
* remove faraday version * add Gemfile.lock
* Remove Job model * remove template model * remove template model * Remove client model * rubocop fix * rubocop
* add element_name * update based on Tony's feedback
* Add dry types gem and Job::Add schema * Add function and test for add job * use string keys instead of symbol keys
* Need to use symbols so we can define optional attributes * Add client schema and spec * Use validated client to send to XPM * Rubocop fix * code review feedback * code review updates
* readme updates * update code owners
Add update, delete and add methods to Staff
…details Flow 181/rate limit exceeded details
wrap Faraday::ConnectionFailed exception
…Error exception (#62)
* Fix response encoding * rubocop Co-authored-by: Chris Nelson <git@chrisnelson.io>
* Unrestrict dry-types version and fix changes * Fix rubocop offences Co-authored-by: Chris Nelson <git@chrisnelson.io>
* Fix contacts array when creating or updating client * Fix specs
* Specific error types for differentiation * Update version number
* Add Client GET /search action * Add specs and VCR cassettes for Client GET /search action * Update Gemfile.lock * Update to Ruby 3.1.3 * Bump gem version to 0.3.0
Co-authored-by: Christopher Nelson <git@chrisnelson.au>
anathematic
reviewed
Jan 8, 2025
|
|
||
| class InternalServerError < Error; end | ||
|
|
||
| class Conflict < Error; end |
There was a problem hiding this comment.
🤷 How do we decide what's a ConflictError vs. just a Conflict class? I guess that proposal from Anton never really stuck huh?
Author
There was a problem hiding this comment.
It might have just not stuck in my head 😆
anathematic
reviewed
Jan 8, 2025
anathematic
left a comment
anathematic
left a comment
There was a problem hiding this comment.
I love I can still add my 2c to this repo. I ain't ever unfollowing it 😉
Author
|
LOL hey @anathematic |
walhalign
approved these changes
Jan 8, 2025
|
@anathematic YOU DA BEST |
StefanSlehta
approved these changes
Jan 8, 2025
Wait.. Hey you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent (What)
Handle the 409 error as an explicit error code
https://ignition.sentry.io/issues/4849254140/?environment=production&project=1314270&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20%22XpmRuby%3A%3AUnknownError%22&referrer=issue-stream&sort=date&statsPeriod=30d&stream_index=1&utc=true