fix: restore the Equals/GetHashCode contract on B2Vec2 - #95
Merged
Conversation
Moving operator== to an IEEE compare was the right call, it matches C. But Equals just forwarded to the operator, so a NaN vector stopped being equal to itself and stopped agreeing with GetHashCode. That breaks Dictionary<B2Vec2, _>. Keep the operator on IEEE semantics and compare bitwise in Equals. While here: - b2World_Draw takes the debug draw by in. C passes b2DebugDraw*, and the struct has 27 fields, so it was copied every frame. - b2GrowBitSet guards its copy the way b2CreateBitSet already guards the fill. Growing a bit set created with zero capacity threw, because b2Alloc hands back null there. - b2ClearBit takes an int like the other three, so the call sites drop their casts. - b2InternalAssert is public. It is B2_API upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving operator== to an IEEE compare was the right call, it matches C. But Equals just forwarded to the operator, so a NaN vector stopped being equal to itself and stopped agreeing with GetHashCode. That breaks Dictionary<B2Vec2, _>. Keep the operator on IEEE semantics and compare bitwise in Equals.
While here: