fix(core): release owning call-result/argument temporaries when a call throws#428
Draft
Guikingone wants to merge 1 commit into
Draft
Conversation
When a chained method call like $t->make()->boom() throws, the intermediate owning temporary from make() was leaked because longjmp bypassed the straight-line release code. This adds a runtime pending- cleanup stack (TLS global array) that records owning temporaries before a potentially-throwing call. If the call throws, __rt_throw_current drains the stack via __rt_eh_drain (calling __rt_decref_any on each entry) before longjmp. On the normal path, eh_pop removes the entry after the call returns. New EIR ops: EhPush (1 operand) and EhPop (0 operands). New runtime helpers: __rt_eh_push, __rt_eh_pop, __rt_eh_drain (AArch64 + x86_64). New globals: _eh_cleanup_stack (2048 bytes), _eh_cleanup_top (8 bytes). Fixes illegalstudio#399
Guikingone
force-pushed
the
fix/399-call-result-temp-leaks-on-throw
branch
from
July 2, 2026 16:18
a5162c0 to
e61819b
Compare
github-actions
Bot
added
area:codegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a chained method call like $t->make()->boom() throws, the intermediate owning temporary from make() was leaked because longjmp bypassed the straight-line release code. This adds a runtime pending- cleanup stack (TLS global array) that records owning temporaries before a potentially-throwing call. If the call throws, __rt_throw_current drains the stack via __rt_eh_drain (calling __rt_decref_any on each entry) before longjmp. On the normal path, eh_pop removes the entry after the call returns.
New EIR ops: EhPush (1 operand) and EhPop (0 operands). New runtime helpers: __rt_eh_push, __rt_eh_pop, __rt_eh_drain (AArch64 + x86_64).
New globals: _eh_cleanup_stack (2048 bytes), _eh_cleanup_top (8 bytes).
Fixes #399