illumos/dev-guide#40 Update for gerrit, illumos-docs by rmustacc · Pull Request #50 · illumos/dev-guide

rmustacc · 2023-08-09T22:20:44Z

This overhauls a number of different sections that are out of date, like webrev, etc. It also incorporates parts of #38.

illumos/dev-guid#49 Update glossary page about lint Portions contributed by: Richard Lowe <richlowe@richlowe.net>

richlowe

just nits

richlowe · 2023-08-09T22:23:23Z

anatomy

-`OBJS` and `SRCS`. We use both throughout the build and to help drive things
-like `lint`. In `OBJS` we place a list of our object files. In this case we only
+`OBJS`. We use both throughout the build and to help drive
+otehr targets. In `OBJS` we place a list of our object files. In this case we only


Addressed, thanks.

richlowe · 2023-08-09T22:23:39Z

anatomy

-before. Finally, we end things with an include of `Makefile.targ` from inside of
+From here on out, things stay relatively straightforward. Previously we
+didn't worry about a `clean` target, but now that we've generated
+intermeidate object files we have to go through and clean them up.


Intermediate

Addressed, thanks.

richlowe · 2023-08-09T22:24:02Z

anatomy

-variable. The second is to change how we're handling the `lint` target.
-Currently the `lint` target is set to `lint_PROG`. We need to change that to
-`lint_SRCS`. While the `SRCS` assignment we made in `Makefile.com` earlier may
+variable. to While the `SRCS` assignment we made in `Makefile.com` earlier may


Weirdness here, not sure what happened

Leftovers from attempting to deal with SRCS which is no longer really required I think.

pfmooney · 2023-08-09T22:42:36Z

integrating

-return when you have corrected those issues. The advocates is made up of members
-of the community and while they have commit access to the gate, they are also
-required to go through the same process.
+RTI is sent to the the core team. n core team member who is familiar with the


"n core team member"

Fixed, thanks.

pfmooney · 2023-08-09T22:43:15Z

integrating

+RTI is sent to the the core team. n core team member who is familiar with the
+subject matter will review the materials and either accept it or not. If the
+change isn't accepted for whatever reason, then the core team member will
+explain why and work with to get things integrated. Most of the time, the core


"work with to"

Hopefully this is better.

pfmooney · 2023-08-09T22:43:59Z

integrating

+or confirmation about a change. The core team members go through this same
+process.


perhaps amend to say "go through this same process when integrating their own changes"?

Thanks, included.

pfmooney · 2023-08-09T22:44:16Z

integrating

  * List of Reviewers

-  * Explanation of Testing
+  * Explanation of Testing in the ticket


why is testing capitalized?

Probably because when I did this almost a decade ago I was trying to think of it like a section title ala reviewers above. Cleaned up.

pfmooney · 2023-08-09T22:44:58Z

integrating

-things between you and your reviewers, that is something that you need to tell
-the advocates.
+things between you and your reviewers, that is something that you should
+mention in the core team. It's okay to still submit the change.


"mention in the core team"?

Should have been "mention to". Fixed.

pfmooney · 2023-08-09T22:46:36Z

integrating

+Like the rest of us, members of the core team are human, and occasionally a
+given change might fall through the cracks. It could be that the core team
+member most familiar with your area is not available and someone is waiting for
+them tog et back. If a core team member needs time to review the contents of


Fixed, thanks.

rmustacc

Thanks @pfmooney and @richlowe. I've tried to clean up everything here.

rmustacc · 2023-08-10T00:11:21Z

anatomy

-variable. The second is to change how we're handling the `lint` target.
-Currently the `lint` target is set to `lint_PROG`. We need to change that to
-`lint_SRCS`. While the `SRCS` assignment we made in `Makefile.com` earlier may
+variable. to While the `SRCS` assignment we made in `Makefile.com` earlier may


Leftovers from attempting to deal with SRCS which is no longer really required I think.

rmustacc · 2023-08-10T00:11:27Z

anatomy

-before. Finally, we end things with an include of `Makefile.targ` from inside of
+From here on out, things stay relatively straightforward. Previously we
+didn't worry about a `clean` target, but now that we've generated
+intermeidate object files we have to go through and clean them up.


Addressed, thanks.

rmustacc · 2023-08-10T00:11:36Z

anatomy

-`OBJS` and `SRCS`. We use both throughout the build and to help drive things
-like `lint`. In `OBJS` we place a list of our object files. In this case we only
+`OBJS`. We use both throughout the build and to help drive
+otehr targets. In `OBJS` we place a list of our object files. In this case we only


Addressed, thanks.

rmustacc · 2023-08-10T00:12:14Z

integrating

-return when you have corrected those issues. The advocates is made up of members
-of the community and while they have commit access to the gate, they are also
-required to go through the same process.
+RTI is sent to the the core team. n core team member who is familiar with the


Fixed, thanks.

rmustacc · 2023-08-10T00:14:39Z

integrating

+RTI is sent to the the core team. n core team member who is familiar with the
+subject matter will review the materials and either accept it or not. If the
+change isn't accepted for whatever reason, then the core team member will
+explain why and work with to get things integrated. Most of the time, the core


Hopefully this is better.

rmustacc · 2023-08-10T00:14:56Z

integrating

+or confirmation about a change. The core team members go through this same
+process.


Thanks, included.

rmustacc · 2023-08-10T00:16:09Z

integrating

  * List of Reviewers

-  * Explanation of Testing
+  * Explanation of Testing in the ticket


Probably because when I did this almost a decade ago I was trying to think of it like a section title ala reviewers above. Cleaned up.

rmustacc · 2023-08-10T00:16:40Z

integrating

-things between you and your reviewers, that is something that you need to tell
-the advocates.
+things between you and your reviewers, that is something that you should
+mention in the core team. It's okay to still submit the change.


Should have been "mention to". Fixed.

rmustacc · 2023-08-10T00:17:02Z

integrating

+Like the rest of us, members of the core team are human, and occasionally a
+given change might fall through the cracks. It could be that the core team
+member most familiar with your area is not available and someone is waiting for
+them tog et back. If a core team member needs time to review the contents of


Fixed, thanks.

rmustacc · 2023-08-22T14:32:36Z

Thanks all. I've landed this manually in d8fb997 so I could keep the commit message correct.

#40 Update for gerrit, illumos-docs

c8fdf20

illumos/dev-guid#49 Update glossary page about lint Portions contributed by: Richard Lowe <richlowe@richlowe.net>

richlowe reviewed Aug 9, 2023

View reviewed changes

pfmooney reviewed Aug 9, 2023

View reviewed changes

fixup

968d29c

rmustacc commented Aug 10, 2023

View reviewed changes

richlowe approved these changes Aug 21, 2023

View reviewed changes

rmustacc closed this Aug 22, 2023

		or confirmation about a change. The core team members go through this same
		process.

Conversation

rmustacc commented Aug 9, 2023

Uh oh!

richlowe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmustacc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmustacc commented Aug 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants