Prevent NotificationWatcher freezes and excessive energy use - #1
Open
weimo123 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NotificationWatcher currently runs a recursive Accessibility-tree traversal from a repeating main-run-loop Timer every 1.5 seconds. Each element is queried through several synchronous cross-process AX calls.
This has two related failure modes:
A process sample of the released 1.0.0 build showed the timer callback on the main thread spending its active samples in NotificationWatcher.collectTexts and AXUIElementCopyAttributeValue IPC.
Changes
Validation
The OTP extraction behavior itself is unchanged.