Merged
Conversation
…eption on AuthConfig
krzysztofchadynka
approved these changes
Aug 7, 2025
Contributor
krzysztofchadynka
left a comment
krzysztofchadynka
left a comment
There was a problem hiding this comment.
LGTM - only two little suggestions
| * @throws AndroidServiceException|JsonException | ||
| * @link https://developers.google.com/android-publisher/api-ref/rest/v3/purchases.subscriptionsv2 Purchases.subscriptionsV2 | ||
| * */ | ||
| * @phpcs:enable |
Contributor
There was a problem hiding this comment.
I think only @link part needs to be excluded from phpcs checking - am I right? If so, change it please:
/**
* @phpcs:disable Generic.Files.LineLength.TooLong
* @link https://developers.google.com/android-publisher/api-ref/rest/v3/purchases.subscriptionsv2 Purchases.subscriptionsV2
* @phpcs:enable
*@throws AndroidServiceException|JsonException
*/
| * @phpcs:disable Generic.Files.LineLength.TooLong | ||
| * @throws AndroidServiceException|JsonException | ||
| * @link https://developers.google.com/android-publisher/api-ref/rest/v3/monetization.subscriptions Monetization.subscriptions | ||
| * @phpcs:enable |
Contributor
There was a problem hiding this comment.
Same question as above? ;)
SniffleSneeze
changed the title
krzysztofchadynka
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Bugfix - add missing
%in service the yaml that was stoping the variable from being properly loadedFeat - Throw a
throwAndroidServiceExceptionwhen getingAuthConfigfix - PHPCS