Introduces lighting#146
Merged
Merged
Conversation
Added the environmentMap attribute and environmentMapReady promise to the IDL, Added initial language about the use of a PBR shading model and IBL. fixes 48 fixes 47
Collaborator
Author
|
We have discussed taking the concept of lighting further but I'd love to start with the most basic definition - is this missing anything from the discussions to date? |
cabanier
approved these changes
Mar 13, 2026
Member
cabanier
left a comment
cabanier
left a comment
There was a problem hiding this comment.
This look OK for now but it will need an algorithm that descibes how the promise is created, the map is parsed, etc
Member
|
I see there are conflicts in the index.html. I usually put the output html in its own branch and publish that with github pages. |
github-actions Bot
added a commit
that referenced
this pull request
Mar 13, 2026
SHA: 33d49e5 Reason: push, by zachernuk Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the environmentMap attribute and environmentMapReady promise to the IDL, Added initial language about the use of a PBR shading model and IBL.
I'm open to more granular specification of the requirements here, but I think we would be better off referencing some other specification, or to add language that indicates that these are UA/OS decisions.
I don't believe anyone has an interest in providing a ground shadow for the in-line element, so I've also removed the issue related to that.
fixes #48
fixes #47
Preview | Diff