build: drop ninja as dependency and use shared cipd script - #390
Merged
Merged
Conversation
|
The PR appears safe to merge based on the reviewed changes. Reviews (1) · Last reviewed commit: "build: drop ninja as dependency and use ..." |
wukko
previously approved these changes
Sep 14, 2026
There was a problem hiding this comment.
Review completed with no actionable findings.
Review walkthrough
Changes
| Files | Summary |
|---|---|
docker/build.Dockerfilescripts/shared.shhelium/devutils/install_cipd_deps.py |
Ninja is retained only where non-x86 LLVM/Rust builds require it; the shared CIPD installer now provisions host GN, Siso, and TypeScript before GN generation and the Siso build. |
helium-chromiumhelium/patches/seriespatches/series |
The submodule advance supplies the shared installer and related Helium updates. The Linux platform patches and their ordering are unchanged from the merge base, so their materialized additions do not represent new platform-patch intent. |
Review checks
| Check | Result | Notes |
|---|---|---|
| Scope | ✅ Passed | Comparison against the merge base confirmed that the feature-template hunk in 'change.diff' is base-branch-only; the PR changes only the Dockerfile, shared build script, and submodule pointer. |
| Project Policy | ✅ Passed | No upstream Chromium test file, case, data, expectation, or test target is modified by the reviewable change. |
| Correctness And Safety | ✅ Passed | Tool provisioning order, failure propagation, host and cross-build architecture handling, and explicit Siso selection were checked without a discrepancy. |
| Chromium Idioms | ✅ Passed | The shared installer reads pinned CIPD manifests through Chromium's 'gclient_eval' and installs the DEPS-owned locations consumed by Chromium's GN and Siso wrappers. |
| Simplicity And Decomposition | ✅ Passed | The change removes duplicated CIPD version lookup and local GN bootstrap logic in favor of the shared Helium installer. |
| Patch Organization | ✅ Passed | The unchanged Linux patch series remains prerequisite-ordered, and the submodule advance is required before 'scripts/shared.sh' can invoke the new installer. |
Analysis record
- Changed files considered: 3
- Findings: 0 new, 0 retained, 0 resolved
- Source snapshot:
6af469f2607e - Codex:
gpt-5.6-sol, reasoninghigh, fast mode on, web search cached - Patch application: clean
- Chromium context tool calls: none
- Maintainer conventions applied:
script-resource-lifecycle
Limitations
- None reported.
This comment has been minimized.
This comment has been minimized.
dumbmoron
force-pushed
the
no-more-ninja
branch
from
September 14, 2026 15:29
e2d1b57 to
e93ba80
Compare
wukko
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.