Fix proguard compile error caused by metadata-extractor module#26
Fix proguard compile error caused by metadata-extractor module#26finnholland wants to merge 1 commit intoinaturalist:mainfrom
Conversation
* increment the metadata extractor package from preview to release
jtklein
force-pushed
the
metadata-extractor-stable
branch
from
1dcf48c to
30eabd9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the metadata-extractor library dependency from a commit hash reference to a semantic version number.
- Changes the dependency reference from a Git commit SHA (
321551df00) to a proper semantic version (2.19.0)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| implementation 'androidx.exifinterface:exifinterface:1.1.0' | ||
| implementation 'it.sephiroth.android.exif:library:+' | ||
| implementation 'com.github.drewnoakes:metadata-extractor:321551df00' | ||
| implementation 'com.github.drewnoakes:metadata-extractor:2.19.0' |
There was a problem hiding this comment.
Using the JitPack reference 'com.github.drewnoakes:metadata-extractor' with a version number is problematic. The metadata-extractor library is published to Maven Central and should be referenced as 'com.drewnoakes:metadata-extractor:2.19.0' instead. The 'com.github.*' group ID is used by JitPack for building from GitHub, but this library has official Maven Central releases that should be preferred.
| implementation 'com.github.drewnoakes:metadata-extractor:2.19.0' | |
| implementation 'com.drewnoakes:metadata-extractor:2.19.0' |
There was a problem hiding this comment.
@budowski do you remember any reason why we pinned this dependency to this specific commit (drewnoakes/metadata-extractor@321551df00), and are not using the maven version here?
2 participants
Proguard failed when run with minify and shrink due to a missing class in
metadata-extractorERROR: R8: Missing class java.awt.Point (referenced from: void com.drew.metadata.mp4.boxes.TrackHeaderBox.addMetadata(com.drew.metadata.mp4.Mp4Directory))This issue has been fixed since so I'm upgrading to
2.19.0I tested locally and it seems to be working correctly but feel free to confirm.