fix(deploy): enable Firecracker virtio-fs in cloud templates - #58
Merged
Conversation
Add the Firecracker runtime section to the Aliyun and HuaweiCloud Terraform values templates. Their complete sandboxd configuration strings override the chart defaults, so they must explicitly enable virtio-fs for OCI and Nydus roots and specify the packaged virtiofsd path. Keep AsyncDirect and Writeback aligned with the bundled configuration. Preserve both providers' storage settings, including Aliyun's native XFS layout with filestore_dir_size unset. Signed-off-by: Tianyu Zhou <albert.zty@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Aliyun and HuaweiCloud Terraform templates replace the chart's entire
node.config.sandboxd.configstring. As a result, the Firecracker virtio-fs defaults added in #57 are lost in those deployments, leaving OCI/Nydus directory roots disabled even though the image includes virtiofsd.Add the same Firecracker section to both templates: enable virtio-fs, select
/usr/local/bin/virtiofsd, and setAsyncDirectwithWriteback. Preserve the existing storage settings, including Aliyun's native XFS layout withfilestore_dir_sizeunset.Validation: rendered both templates with Terraform
templatefile, passed the generated values through Helm, and parsed the final ConfigMap's TOML with runc both enabled and disabled. All four cases retain the expected Firecracker settings and correct runc registration. Confirmed all other TOML content is unchanged andgit diff --checkpasses. No cloud resources were deployed.