Add qwen3-vl-dense support and example on Ascend#868
Add qwen3-vl-dense support and example on Ascend#868HwVanICI wants to merge 2 commits intoinclusionAI:mainfrom
Conversation
Summary of ChangesHello @HwVanICI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the capabilities of the system by integrating support for Qwen3-VL dense models on Ascend NPUs. It includes crucial adjustments to the FSDP engine for proper model parameter handling and provides practical training examples, enabling users to leverage these advanced vision-language models effectively on the specified hardware. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for Qwen3-VL dense models on Ascend, including updates to the FSDP engine for parameter name compatibility and new training examples. The changes look good overall. I've left a few minor comments regarding a typo in the documentation and some formatting suggestions in the new shell scripts to improve consistency.
|
|
||
| This directory contains examples for training vision-language models on NPU with GRPO: | ||
|
|
||
| 1. **Qwen2.5-VL-3B** - `qwen2_5_vl_3b_geometry3k_grpo.*` - GRPO training on Geometry3K with Qwen2.5-VL-2B model dataset |
There was a problem hiding this comment.
There appears to be a typo in the model name. To maintain consistency with the section title and configuration files, it should be Qwen2.5-VL-3B instead of Qwen2.5-VL-2B.
| 1. **Qwen2.5-VL-3B** - `qwen2_5_vl_3b_geometry3k_grpo.*` - GRPO training on Geometry3K with Qwen2.5-VL-2B model dataset | |
| 1. **Qwen2.5-VL-3B** - `qwen2_5_vl_3b_geometry3k_grpo.*` - GRPO training on Geometry3K with Qwen2.5-VL-3B model dataset |
|
Hi @HwVanICI , could you rebase the current main and resolve the conflict firest? |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
bc2a56b to
4b29d69
Compare
The branch is rebased to main. |
Description
This PR adds support for training the Qwen3-VL dense models on Ascend NPU and provides training examples for Qwen3-VL-2B model on the Geometry3K dataset with GRPO.
Key change
Updated FSDP engine to correctly handle Qwen-VL model parameter names to ensure compatibility with vLLM-Ascend's internal model naming convention.
Type of Change
work as expected)
Checklist
jb build docs/gemini review)