feat(ui): parse and validate custom-theme colour values into SGR#475
Merged
Conversation
User themes hinge on safe colour parsing: each role's colour is validated to integers and the SGR escape is rebuilt by malt, so an untrusted theme file can never inject terminal escapes. Accepts #rgb/#rrggbb hex, [r,g,b] arrays and 256-colour indexes; every other or escape-bearing value is rejected.
indaco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the pure core for user-defined colour themes: the runtime palette/registry types and a colour-value parser that accepts only
#rgb/#rrggbbhex,[r, g, b]integer arrays, and a single0–255256-colour index - and constructs the SGR escape string itself from validated integers. No file is read yet and nothing consults these types; this lands the security-critical, injection-proof conversion as one fully-tested leaf ahead of the loader.Any malformed or escape-bearing value is rejected, never emitted: out-of-range ints, wrong-length or non-hex strings, wrong-arity / non-integer arrays, and - critically - anything carrying
ESC,;, ormcannot be smuggled, because the output is built from parsedu8s only. CSS-stylergba(),hsl(), named colours and 8-digit RGBA hex are explicitly rejected.The leaf imports only
std(plusthemesfor the sharedRole/Polarity/NamedPalette), preserving the CLI/TUI →color/themesdependency direction.Related Issue
Notes for Reviewers
This is part 2 of 2 in a stack made with GitButler: