Repository navigation
Conversation
ThiefMaster
reviewed
Oct 13, 2026
ThiefMaster
reviewed
Oct 13, 2026
| if registration.state == RegistrationState.complete) | ||
| return registrations | ||
|
|
||
| def _schedule_backfill(self, vc_room, registrations): |
Member
There was a problem hiding this comment.
How badly will things break if you enable autoreg (ie the task is triggered) and then disable it again, before that task finished? :)
Contributor
Author
There was a problem hiding this comment.
They'd overlap. To mitigate that, I was thinking of adding a check that verifies that auto_registration is on before onboarding more users (in every 30-user batch I mean). What do you think?
Contributor
Author
There was a problem hiding this comment.
I took the liberty of doing so in f030dc1. Anyway it doesn't hurt.
moliholy
force-pushed
the
fix/vc-zoom-registrant-dedup-lookups
branch
from
October 16, 2026 10:28
88c2063 to
3b83ca7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling auto-registration on a Zoom room, and syncing a single registration, resolved every registrant of the event against the Zoom API inside the request. On events with hundreds of registrants outside the Zoom account this meant hundreds of API calls per request, and the request timed out.
This PR:
DEBUGmode, still run within the request.