Skip to content

Add suites for Bulk Data Submit v4.0.0-ballot - #58

Open
holmesie wants to merge 8 commits into
inferno-framework:mainfrom
holmesie:submit
Open

holmesie wants to merge 8 commits into
inferno-framework:mainfrom
holmesie:submit

Conversation

@holmesie

@holmesie holmesie commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds preliminary Bulk Data Submit v4.0.0-ballot conformance test suites for data providers and consumers.

Testing Guidance

You can run the Data Provider and Data Consumer suites against each other to
see how the tests work:

  1. Start a session in the Bulk Data Access v4.0.0 Submit - Data Provider (Preview) suite.
  2. Select the "Demo: Run Data Provider Against Inferno Data Consumer" preset.
  3. Click the "Run All Tests" button.
  4. In another browser tab, start a session in the Bulk Data Access v4.0.0
    Submit - Data Consumer (Preview) suite.
  5. Select the "Demo: Run Data Consumer Against Inferno Data Provider" preset.
  6. Click the "Run All Tests" button.
  7. When the Data Consumer suite pauses after sending completed, advance the
    Data Provider suite from its initial wait.
  8. The Data Provider suite will retrieve the manifest and file synchronously,
    then pause while waiting for the final status poll.
  9. Advance the Data Consumer suite. It will make one final status poll.
  10. After that poll completes, advance the Data Provider suite to finish the
    paired workflow.

Comment thread lib/bulk_data_test_kit/v4.0.0/submit/provider/docs/suite_description.md Outdated
@arscan

arscan commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@karlnaden -- ONC would like to have this available on inferno-qa for the Connectathon starting for Sept 19th. I think any of the following solutions are reasonable:

  • Have inferno-qa point to this branch
  • Merge this to main and point inferno-qa to main
  • Merge this to main, perform a new release of this test kit, and put that on inferno-qa, with the intent of getting it on inferno.healthit.gov whenever your next regular deployment in.

This should be stable enough to merge to main and do a release, but that does take a little bit of time and there isn't a rush.

Or if you have other thoughts, let me know.

Thanks,
Rob

@karlnaden

Copy link
Copy Markdown
Contributor

think any of the following solutions are reasonable:

@arscan I don't have a strong preference, but I lean towards releasing it as a gem. The reason not to do that would be if this "ballot" test kit would need to be removed later. However, it looks to me like the underlying Inferno entity ids (suite, groups, tests) are written as if they are 4.0.0 suites, so when the final version is published, it can be updated to reflect that final version without the need to create another suite or adjust those ids. The documentation is clear that these are not final suites. The only thing I would suggest doing is making more explicit that these are based on a ballot specification that hasn't been published yet (see comments).

Considerations that might change my mind:

  1. If the intention is not to have these up on qa or prod following the connectathon, then I would lean toward using the current branch in QA.
  2. If ONC is not currently planning on having MITRE continue to own and finish development on these suites after the 4.0.0 publication, then I'd be a little hesitant to release it as a gem and commit Acro to maintaining early-stage draft test suites. If that's the case, then I'd also propose to use the current branch in QA and plan to get a little more clarity on the future plans before merging into main and releasing as a gem.

Let me know if you have thoughts on those two considerations.

@arscan

arscan commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

(see comments)

I'm sorry, did you mean to put comments inline against the content itself, or what this just referring to being more explicit about being against a -ballot version of the IG?

I believe the intent is to get these on prod afterwards, and I assume that the MITRE team will be supporting the move from -ballot to final, but I'll get clarity on that. Good questions.

Comment on lines +7 to +11
These tests are a **PREVIEW** intended to allow implementers to perform
preliminary checks of their systems against the requirements stated for Bulk Submit actors
and [provide feedback](https://github.com/inferno-framework/bulk-data-test-kit/issues)
on the tests. Future versions of these tests may verify other
requirements and may change the test verification logic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this with a link should be added here and in other places like the metadata that refer to this as a "PREVIEW"

Suggested change
These tests are a **PREVIEW** intended to allow implementers to perform
preliminary checks of their systems against the requirements stated for Bulk Submit actors
and [provide feedback](https://github.com/inferno-framework/bulk-data-test-kit/issues)
on the tests. Future versions of these tests may verify other
requirements and may change the test verification logic.
These tests are a **PREVIEW** built using a ballot version of the Bulk 4.0.0 specification and
intended to allow implementers to perform preliminary checks of their systems against the
requirements stated for Bulk Submit actors and [provide feedback](https://github.com/inferno-framework/bulk-data-test-kit/issues)
on the tests. Future versions of these tests may verify other
requirements and may change the test verification logic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @holmesie. Instead of me making a fork of your fork to do a PR into this PR, maybe it makes sense for you to take a pass at this PR with these requested updates.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the language

@karlnaden

Copy link
Copy Markdown
Contributor

I'm sorry, did you mean to put comments inline against the content itself, or what this just referring to being more explicit about being against a -ballot version of the IG?

Oops - added now: https://github.com/inferno-framework/bulk-data-test-kit/pull/58/changes#r3992276358

@karlnaden karlnaden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and documentation looks good. As long as you've confirmed that this should be deployed to production after the connectathon and that MITRE will be responsible for completing the tests upon publication of the v4.0.0 IG version, it can be merged.

smunini added a commit to HeliosSoftware/bulk-data-test-kit that referenced this pull request Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants