Conversation
|
@karlnaden -- ONC would like to have this available on inferno-qa for the Connectathon starting for Sept 19th. I think any of the following solutions are reasonable:
This should be stable enough to merge to main and do a release, but that does take a little bit of time and there isn't a rush. Or if you have other thoughts, let me know. Thanks, |
@arscan I don't have a strong preference, but I lean towards releasing it as a gem. The reason not to do that would be if this "ballot" test kit would need to be removed later. However, it looks to me like the underlying Inferno entity ids (suite, groups, tests) are written as if they are 4.0.0 suites, so when the final version is published, it can be updated to reflect that final version without the need to create another suite or adjust those ids. The documentation is clear that these are not final suites. The only thing I would suggest doing is making more explicit that these are based on a ballot specification that hasn't been published yet (see comments). Considerations that might change my mind:
Let me know if you have thoughts on those two considerations. |
I'm sorry, did you mean to put comments inline against the content itself, or what this just referring to being more explicit about being against a -ballot version of the IG? I believe the intent is to get these on prod afterwards, and I assume that the MITRE team will be supporting the move from -ballot to final, but I'll get clarity on that. Good questions. |
| These tests are a **PREVIEW** intended to allow implementers to perform | ||
| preliminary checks of their systems against the requirements stated for Bulk Submit actors | ||
| and [provide feedback](https://github.com/inferno-framework/bulk-data-test-kit/issues) | ||
| on the tests. Future versions of these tests may verify other | ||
| requirements and may change the test verification logic. |
There was a problem hiding this comment.
Something like this with a link should be added here and in other places like the metadata that refer to this as a "PREVIEW"
| These tests are a **PREVIEW** intended to allow implementers to perform | |
| preliminary checks of their systems against the requirements stated for Bulk Submit actors | |
| and [provide feedback](https://github.com/inferno-framework/bulk-data-test-kit/issues) | |
| on the tests. Future versions of these tests may verify other | |
| requirements and may change the test verification logic. | |
| These tests are a **PREVIEW** built using a ballot version of the Bulk 4.0.0 specification and | |
| intended to allow implementers to perform preliminary checks of their systems against the | |
| requirements stated for Bulk Submit actors and [provide feedback](https://github.com/inferno-framework/bulk-data-test-kit/issues) | |
| on the tests. Future versions of these tests may verify other | |
| requirements and may change the test verification logic. |
There was a problem hiding this comment.
FYI @holmesie. Instead of me making a fork of your fork to do a PR into this PR, maybe it makes sense for you to take a pass at this PR with these requested updates.
There was a problem hiding this comment.
Tweaked the language
Oops - added now: https://github.com/inferno-framework/bulk-data-test-kit/pull/58/changes#r3992276358 |
karlnaden
left a comment
There was a problem hiding this comment.
Code and documentation looks good. As long as you've confirmed that this should be deployed to production after the connectathon and that MITRE will be responsible for completing the tests upon publication of the v4.0.0 IG version, it can be merged.
Summary
Adds preliminary Bulk Data Submit v4.0.0-ballot conformance test suites for data providers and consumers.
Testing Guidance
You can run the Data Provider and Data Consumer suites against each other to
see how the tests work:
Submit - Data Consumer (Preview) suite.
completed, advance theData Provider suite from its initial wait.
then pause while waiting for the final status poll.
paired workflow.