introducing a radio button component and a radio button group component#583
Open
daviddkkim wants to merge 4 commits intoinfluxdata:masterfrom
Open
introducing a radio button component and a radio button group component#583daviddkkim wants to merge 4 commits intoinfluxdata:masterfrom
daviddkkim wants to merge 4 commits intoinfluxdata:masterfrom
Conversation
Contributor
Author
|
In terms of margin, button size, font size, .. etc, I followed the exact style guide as is but the contrast in the size of radio input and the font feels odd to me. I didn't want to diverge from the style guide and introduce arbitrary styling so I left it as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #580
Changes
// Describe what you changed
I introduced a radio button and radio button group as indicated in issue #580.
@jrenee42 - I didn't see that you assigned yourself to the issue until just now. This isn't quite done yet (no color options, .. etc) but I just thought I'd submit what I have in hopes that it can be helpful. If not, no worries - feel free to squash this PR!
One notable offshoot is that Instead of taking the array of string values for labels as you suggested, I have it so that it accepts children radio buttons. I started with the singular Radio button so I thought this would allow me to use that to the fullest.
Screenshots
// Add screenshots here if relevant




Checklist
Check all that apply