Open
Conversation
mavarius
force-pushed
the
add-markdown-docs
branch
from
a3e5198 to
5d246ff
Compare
chnn
previously approved these changes
Jun 10, 2019
Contributor
chnn
left a comment
chnn
left a comment
There was a problem hiding this comment.
Neat. I left two comments about some minor administrative stuff.
I think eventually it would be nice to have a non-storybook docs site. Storybook is quick and nice for experimenting, but feels pretty awkward overall as a way to learn a library.
| "jest": "^24.5.0", | ||
| "markdown-loader": "^5.0.0", | ||
| "marked": "^0.6.2", | ||
| "node-sass": "^4.12.0", |
Contributor
There was a problem hiding this comment.
Can we use Dart Sass (https://www.npmjs.com/package/sass) instead? node-sass can be a pain to install due to the native deps.
mavarius
force-pushed
the
add-markdown-docs
branch
from
dfcda09 to
544dd2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add markdown support and storybook styles.