Skip to content

fix: fix PHP 8.5 deprecations#170

Merged
karel-rehor merged 2 commits into
influxdata:masterfrom
Roman3349:update/php
Jul 21, 2026
Merged

fix: fix PHP 8.5 deprecations#170
karel-rehor merged 2 commits into
influxdata:masterfrom
Roman3349:update/php

Conversation

@Roman3349

@Roman3349 Roman3349 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@Roman3349
Roman3349 force-pushed the update/php branch 3 times, most recently from fb7a08e to d154e0d Compare July 11, 2026 17:33
@karel-rehor
karel-rehor self-requested a review July 21, 2026 11:18
Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (052cecf) to head (e5ac03b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #170   +/-   ##
=========================================
  Coverage     75.09%   75.09%           
  Complexity      455      455           
=========================================
  Files            25       25           
  Lines          1104     1104           
=========================================
  Hits            829      829           
  Misses          275      275           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karel-rehor

Copy link
Copy Markdown
Contributor

@Roman3349

Ahoj Romane,

I'm reconfiguring the build settings, while it looks like you are updating your fork and this PR. At first glance these changes look good. I saw that PHP 7.4 reached end of life 3 and a half years ago, so I removed all 7.x versions from the required build settings. The product manager for this is currently on holiday. But, I think this is correct. We'll review this decision when he returns. But, I'd rather not wait until then to finish this PR.

Also looking a the end-of-life PHP release page, I see 8.0 also reached this state six months ago. So maybe the default php-image parameter for the tests-php job should be 8.3.

Let me know when your fork is ready for review.

@Roman3349

Copy link
Copy Markdown
Contributor Author

@karel-rehor Ahoj Karle,

Personally, I would maintain support for the currently supported PHP versions (that is 8.2 - 8.5). Especially since the vast majority (96.5 %) of installations have been done on these versions (see https://packagist.org/packages/influxdata/influxdb-client-php/php-stats#3.8).

I’ve narrowed this PR down to just fixing the deprecated notices in PHP 8.5. I’ll put the rest in a separate PRs. #172 adds a suggested dependency on ext-sockets. So these two PRs are ready for review.

I’ll drop support of unsupported PHP and add native type hints for non-generated classes to another PR when I have some free time over the weekend. I'd also like to test whether the library works with the latest development version of PHP 8.6 (alpha2), if there are any deprecation notices, I'll submit another PR with a fix.

@karel-rehor karel-rehor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the build rules requiring php 8.3 and 8.4 and setting the nightly build to use php 8.5. I agree that these should be supported and hope to see them in an upcoming pull request. After a bit of reflection, perhaps at least php-7.4 should be included in builds for a while longer.

Looks good to me. 🚴 🏁

@karel-rehor
karel-rehor merged commit f6054bf into influxdata:master Jul 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants