fix: fix PHP 8.5 deprecations#170
Conversation
fb7a08e to
d154e0d
Compare
Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
=========================================
Coverage 75.09% 75.09%
Complexity 455 455
=========================================
Files 25 25
Lines 1104 1104
=========================================
Hits 829 829
Misses 275 275 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Ahoj Romane, I'm reconfiguring the build settings, while it looks like you are updating your fork and this PR. At first glance these changes look good. I saw that PHP 7.4 reached end of life 3 and a half years ago, so I removed all 7.x versions from the required build settings. The product manager for this is currently on holiday. But, I think this is correct. We'll review this decision when he returns. But, I'd rather not wait until then to finish this PR. Also looking a the end-of-life PHP release page, I see 8.0 also reached this state six months ago. So maybe the default Let me know when your fork is ready for review. |
|
@karel-rehor Ahoj Karle, Personally, I would maintain support for the currently supported PHP versions (that is 8.2 - 8.5). Especially since the vast majority (96.5 %) of installations have been done on these versions (see https://packagist.org/packages/influxdata/influxdb-client-php/php-stats#3.8). I’ve narrowed this PR down to just fixing the deprecated notices in PHP 8.5. I’ll put the rest in a separate PRs. #172 adds a suggested dependency on I’ll drop support of unsupported PHP and add native type hints for non-generated classes to another PR when I have some free time over the weekend. I'd also like to test whether the library works with the latest development version of PHP 8.6 (alpha2), if there are any deprecation notices, I'll submit another PR with a fix. |
There was a problem hiding this comment.
I've reverted the build rules requiring php 8.3 and 8.4 and setting the nightly build to use php 8.5. I agree that these should be supported and hope to see them in an upcoming pull request. After a bit of reflection, perhaps at least php-7.4 should be included in builds for a while longer.
Looks good to me. 🚴 🏁
Proposed Changes
(double)->(float)Checklist
make testcompletes successfully