Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions faraday_plugins/plugins/repo/shodan/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,17 @@ def parseOutputString(self, output):
for name, vuln_info in vulns.items():
description = vuln_info.get('summary')
references = vuln_info.get('references')
self.createAndAddVulnToService(h_id, s_id, name, desc=description, ref=references
, cve=name)
cvss_score = vuln_info.get('cvss')
cvss2 = {}
severity = vuln_info.get('severity', '')
if cvss_score is not None:
cvss2['base_score'] = cvss_score
if not severity:
severity = get_severity_from_cvss(cvss_score)
self.createAndAddVulnToService(
h_id, s_id, name, desc=description, ref=references,
cve=name, severity=severity, cvss2=cvss2
)

def processCommandString(self, username, current_path, command_string):
"""
Expand Down
32 changes: 32 additions & 0 deletions tests/test_shodan.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import json
from unittest.mock import Mock

from faraday_plugins.plugins.repo.shodan.plugin import ShodanPlugin


def test_shodan_preserves_cvss_score_and_derives_severity():
plugin = ShodanPlugin()
plugin.createAndAddHost = Mock(return_value="host-id")
plugin.createAndAddServiceToHost = Mock(return_value="service-id")
plugin.createAndAddVulnToService = Mock()

plugin.parseOutputString(json.dumps({
"ip_str": "203.0.113.10",
"port": 443,
"transport": "tcp",
"hostnames": ["example.test"],
"vulns": {
"CVE-2024-12345": {
"summary": "Example Shodan vulnerability",
"references": ["https://example.test/CVE-2024-12345"],
"cvss": 7.5,
},
},
}))

plugin.createAndAddVulnToService.assert_called_once()
args, kwargs = plugin.createAndAddVulnToService.call_args
assert args[:3] == ("host-id", "service-id", "CVE-2024-12345")
assert kwargs["severity"] == "high"
assert kwargs["cvss2"] == {"base_score": 7.5}
assert kwargs["cve"] == "CVE-2024-12345"