Add lsmean_se/lsmean_ci/lsmean_diffci stats, weights_emmeans param,#1480
Merged
Conversation
…ram, and export s_ancova()
Contributor
Author
munoztd0
changed the title
munoztd0
changed the title
munoztd0
changed the title
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Contributor
Author
Thanks, for the review ! I addressed everything I could just waiting for feedback from Daniel on one or two things |
Contributor
Author
|
@danielinteractive ok to merge ? |
danielinteractive
approved these changes
Jun 5, 2026
danielinteractive
left a comment
danielinteractive
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @munoztd0 !
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Contributor
Author
|
@Melkiades thanks for all the suggestions and comments, I think we are ready to merge |
Signed-off-by: Davide Garolini <davide.garolini@roche.com>
Contributor
|
why is this empty @munoztd0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes johnsonandjohnson/junco#161
Motivation
These enhancements have been in production use in the
juncopackage(https://github.com/johnsonandjohnson/junco) and are being contributed
back to tern.
Changes
s_ancova():lsmean_se,lsmean_ci,lsmean_diffci— expose per-arm adjusted mean with SE/CI, and acombined diff+CI statistic for single-row display.
These are all NULL default changes and should not cause any breaking changes
PS: Fix some lints from previous PR #1474