LuaLS as language server for Monaco editor by SukuWc · Pull Request #1470 · intechstudio/grid-editor

SukuWc · 2026-04-02T06:07:45Z

Summary

Integrates LuaLS (Lua Language Server) with the Monaco editor via a WebSocket bridge
Spawns LuaLS as a child process on the main thread, bridges stdio ↔ WebSocket for LSP JSON-RPC in the renderer
Adds ---@meta annotations for the Grid Lua API (build-assets/lua-annotations/grid-api.lua) enabling completions, hover, signature help, and semantic tokens

Test plan

Verify completions appear for Grid API globals in the Monaco editor
Verify hover and signature help work on function calls
Verify LuaLS binary downloads correctly via postinstall on all platforms (macOS arm64/x64, Windows, Linux)
Verify app builds and packages correctly with LuaLS binaries in extraResources
Verify CI build matrix includes the LuaLS download step

🤖 Generated with Claude Code

…er, but its commented at least

…g luaLS, try to have feature parity with previous implementation

…ng while working on other apps

…d endless element function highlights

LuaLS runs as a process in Electron main and bridges over ws://localhost:8089. In the web-only CI environment there is no backend, so suggestions never appear and these tests always fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…d to support monaco features

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

kkerti · 2026-07-03T12:02:13Z

code editor on element no language server

Now lua language server should be initialized.

kkerti · 2026-07-03T12:13:32Z

Overflow is now allowed for the monaco widgets
LineEditor has the same context awareness as CodeEditor
Hover and Suggestions are not disabled, instead the widget overflow helps in visualization
Added extra context check for right hand variable declaration in VariableManager

Action blocks impacted:

Greg-Orca · 2026-07-03T12:32:16Z

command+S save

…yntax highlight issues

kkerti · 2026-07-03T13:16:13Z

command+S save

Regression since vscode-api handled save differently
added lualsExpressionOnly flag
extended openEditorContext with self. typings

… over more code

…animationend events, but it broke monaco hover. we don't use these anyway, so just go with transition 0.

kkerti · 2026-07-03T14:38:17Z

Fixed animation lifecycle, so hover info works properly and doesn't do an invalid size calculation between transition frames.

Greg-Orca · 2026-07-06T10:40:57Z

cloud be nice if we disable Global variable check ---@diagnostic disable: undefined-global
resize bug:

no element suggestion

after self. gives suggestion:

…next to suggested functions

…disable global error check

kkerti · 2026-07-06T12:19:53Z

fixed:

global diagnostics are disabled now, until we figure out how code contexts work well with Grid
undefined inject-field diagnostic is disabled, same story as with global
regression fix: element suggestions work now
regression fix: icons are shown next to suggestions
regression fix: monaco resize works now

won't fix:

The valid suggestions are rendered first, and then the invalid ones later.

Not valid suggestions by suggestion provider and provideDefinition for self. and self: (dot and colon) will be reworked with the completion provider in separate PR, possibly with the context extension work.

kkerti · 2026-07-06T15:31:46Z

Regression to fix: file manager panel should load luals or fallback server on init.

…nd y coordinates

…dcasting behavior

- New LegacyCompletionNotification.svelte shown when LuaLS fails to start - Shows warning with Troubleshooting and Dismiss buttons - Guarded by userLevelMinimalist (only shown in advanced mode) - Configuration key DOCUMENTATION_LUALS_TROUBLESHOOTING_URL added - Monaco fallback path sets legacyCompletionActive flag in appSettings

kkerti and others added 30 commits March 5, 2026 21:47

kk allow symlinking the grid-protocol for local dev, might remove lat…

b4ddb82

…er, but its commented at least

kk consume generated luadocs in monaco editor, without actually addin…

b66e4b5

…g luaLS, try to have feature parity with previous implementation

kk format

0ce2f93

kk removed unnecessary log, added new port numbers for easier debuggi…

ee6072e

…ng while working on other apps

kk working version

bfa4ec0

kk proto highlighting

b00f3e7

kk based on vscode luals extension, changed how monaco editor works

b219e28

kk added download methods to respective targets

5780357

kk updated pkg-lock

681f3ea

kk bumped version so package-lock update is picked up

df85fe6

kk update lock, forgot a local path in there

d20f523

kk updata package lock

929845a

kk format

dcf1de9

kk update the playwright app port

2a7d8b9

kk add vitest simple test fix for node 24 compat

38b9c42

kk package lock fix

125fdc9

kk attempt to fix file resolution

8ef9289

kk fix worker build

7db9aab

kk new attempt to fix worker

62282ea

kk removed incompatible lua suggestions from langDef and fixed lcd an…

546d4ed

…d endless element function highlights

kk fix tailwind taking ages to load and fix monaco import

2f77a5d

Merge branch 'kk-dev-startup-update' into kkerti-luaLS

e5cd080

kk fix monaco import, without the full import luals did not work

21f24aa

SUKU lock updated

7c116d4

SUKU context file and language properties moved to stdio instead of fs

1068c9e

SUKU error console is now text-selectable

b5e3b2b

SUKU element and self are now typed, virtual file handling implemente…

b2de4f0

…d to support monaco features

Merge stable into kkerti-luaLS

9bb3ef9

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge stable into kkerti-luaLS, regenerate package-lock.json

95c6249

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

kkerti moved this from In Progress to Ready for QA in Editor Roadmap Jul 3, 2026

Greg-Orca moved this from Ready for QA to Done in Editor Roadmap Jul 3, 2026

Greg-Orca moved this from Done to QA in progress in Editor Roadmap Jul 3, 2026

kkerti added 3 commits July 3, 2026 14:53

kk self. declarations are not showing with this freeform expression s…

3bcb833

…yntax highlight issues

kk expressionOnly added for if and elseif

7bcc9a4

kk fixed commit saving

fbfc03a

kkerti added 2 commits July 3, 2026 15:37

fix the fixed height code editor function name rendering as we scroll…

e5f6509

… over more code

kk fix "reduced motion" hack, which was used to fire transitionend / …

06d5287

…animationend events, but it broke monaco hover. we don't use these anyway, so just go with transition 0.

Greg-Orca moved this from QA in progress to In Progress in Editor Roadmap Jul 6, 2026

kkerti added 5 commits July 6, 2026 13:14

kk regression fix, resizing in inline-view works and icons are shown …

bddff2a

…next to suggested functions

kk until we make editors be aware of more code on a control surface, …

ce5b1ae

…disable global error check

kk added persistent line height preference for inline editor

1588a6a

kk revert context change - needs more research

b8ec5b3

kk inject-field diagnostic disabled

27dd744

kkerti moved this from In Progress to Ready for QA in Editor Roadmap Jul 6, 2026

kkerti moved this from Ready for QA to In Progress in Editor Roadmap Jul 6, 2026

Greg-Orca and others added 6 commits July 6, 2026 21:01

update immediate_send function parameters to allow nil values for x a…

c16e80d

…nd y coordinates

update immediate_send function parameter descriptions to clarify broa…

8495cd8

…dcasting behavior

kk added context and fixed lua language type

e2e641e

kk format

2b121c5

fix web build Mixpanel CORS by switching to Image GET transport

7444eff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

LuaLS as language server for Monaco editor#1470

LuaLS as language server for Monaco editor#1470
SukuWc wants to merge 67 commits into
stablefrom
kkerti-luaLS

SukuWc commented Apr 2, 2026

Uh oh!

kkerti commented Jul 3, 2026

Uh oh!

kkerti commented Jul 3, 2026

Uh oh!

Greg-Orca commented Jul 3, 2026 •

edited

Loading

Uh oh!

kkerti commented Jul 3, 2026

Uh oh!

kkerti commented Jul 3, 2026 •

edited

Loading

Uh oh!

Greg-Orca commented Jul 6, 2026 •

edited

Loading

Uh oh!

kkerti commented Jul 6, 2026 •

edited

Loading

Uh oh!

kkerti commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SukuWc commented Apr 2, 2026

Summary

Test plan

Uh oh!

kkerti commented Jul 3, 2026

Uh oh!

kkerti commented Jul 3, 2026

Uh oh!

Greg-Orca commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkerti commented Jul 3, 2026

Uh oh!

kkerti commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Greg-Orca commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkerti commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

fixed:

won't fix:

Uh oh!

kkerti commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Greg-Orca commented Jul 3, 2026 •

edited

Loading

kkerti commented Jul 3, 2026 •

edited

Loading

Greg-Orca commented Jul 6, 2026 •

edited

Loading

kkerti commented Jul 6, 2026 •

edited

Loading