Skip to content

Feat: firestore profiles now has files field (#1541)#1544

Open
kkerti wants to merge 15 commits into
stablefrom
feature/1541-file-management-profile-cloud
Open

Feat: firestore profiles now has files field (#1541)#1544
kkerti wants to merge 15 commits into
stablefrom
feature/1541-file-management-profile-cloud

Conversation

@kkerti

@kkerti kkerti commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Original issue: #1541

Profile Cloud file management

  • Implements file upload support for Profile Cloud: module "files" field is now synced to Firestore when profiles are saved to the cloud.
  • Refactored FileManager by extracting business logic into a dedicated FileManager.ts, separating concerns from the Svelte component.
  • Moved file operations out of the component layer and into runtime.ts / operations.ts to avoid circular dependencies.
  • Renamed action-string execution functions to execConfigImmediate and added SendLuaImmediateAndEvaluate to instructions.ts for clearer intent.

@kkerti kkerti changed the title Feat: firestore profiles now has files field Feat: firestore profiles now has files field (#1541) Jun 26, 2026
@kkerti kkerti changed the title Feat: firestore profiles now has files field (#1541) Feat: firestore profiles now has files field #1541 Jun 26, 2026
@kkerti kkerti changed the title Feat: firestore profiles now has files field #1541 Feat: firestore profiles now has files field (#1541) Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit de3727c):

https://grid-editor-web--pr1544-feature-1541-file-ma-i0blckx9.web.app

(expires Wed, 05 Aug 2026 15:05:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit de3727c):

https://grid-playwright-result--pr1544-feature-1541-file-ma-urtmnw5k.web.app

(expires Thu, 09 Jul 2026 15:13:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0f764ceb264072188bf1a5dee10613d8f10b4ca2

@Greg-Orca Greg-Orca moved this from Todo to Ready for QA in Editor Roadmap Jul 7, 2026
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Jul 7, 2026
@Greg-Orca

Copy link
Copy Markdown
Contributor

#1541

@Greg-Orca Greg-Orca moved this from QA in progress to In Progress in Editor Roadmap Jul 7, 2026
@kkerti

kkerti commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

From QA session w/ @Greg-Orca

  • On profile cloud card, "Files" should be renamed to indicate that the files belong to the Profile
  • Overwrite on profile should overwrite files as well, follow how Editor works
  • Upload a random profile -> enter the page folder in FileManager -> upload a profile with files -> click on Root -> ERROR
  • Save file to folder in FM -> if you are in folder and disconnect module -> reconnect -> click root -> ERROR
  • Profile load should remove files first from page
    • What if page folder has calibration?
    • What if page has... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants