Skip to content

Comments

feat: add github_user_ssh_signing_key#2366

Open
simonostendorf wants to merge 2 commits intointegrations:mainfrom
simonostendorf:feat/github_user_ssh_signing_key
Open

feat: add github_user_ssh_signing_key#2366
simonostendorf wants to merge 2 commits intointegrations:mainfrom
simonostendorf:feat/github_user_ssh_signing_key

Conversation

@simonostendorf
Copy link

@simonostendorf simonostendorf commented Aug 26, 2024 •
edited
Loading

Resolves #2365

Resolves #1917

Before the change?

  • managing ssh signing keys was not possible

After the change?

  • managing ssh signing keys is possible with github_user_ssh_signing_key resource
  • the resource is equal to the existing github_user_ssh_key resource that manages ssh auth keys

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell
Copy link
Contributor

kfcampbell commented Aug 30, 2024

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@simonostendorf
Copy link
Author

simonostendorf commented Aug 31, 2024

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@kfcampbell sorry forgot that. I added it now.

@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 875d76f to 1dde54f Compare September 15, 2024 08:06
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from f5d9e6d to 3860cf3 Compare September 22, 2024 16:20
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 065e10e to efcc88e Compare September 28, 2024 15:22
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 009fd4b to 4713629 Compare October 10, 2024 11:42
@quotidian-ennui
Copy link

quotidian-ennui commented Oct 16, 2024

#1917 should perhaps be formally linked to this PR as well since it appears equivalent to #2365

@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 4713629 to 8087453 Compare October 16, 2024 09:17
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 8087453 to dd6de65 Compare May 28, 2025 05:38
@simonostendorf
Copy link
Author

simonostendorf commented May 28, 2025

@kfcampbell hey, can we get this merged?

@kilianpaquier
Copy link

kilianpaquier commented Oct 10, 2025

Would love to see this merged

deiga
deiga suggested changes Jan 17, 2026
View reviewed changes
@github-project-automation github-project-automation bot moved this from 🛑 Blocked/Awaiting Response to 🏗 In progress in 🧰 Octokit Active Jan 17, 2026
@deiga
Copy link
Collaborator

deiga commented Jan 17, 2026

Hey @simonostendorf
Sorry that you have needed to wait for so long. Could you rebase your branch and adjust your code to fit our newer standards?

@simonostendorf simonostendorf mentioned this pull request Jan 18, 2026
Open
1 task
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from dd6de65 to 171470e Compare January 18, 2026 05:46
@github-actions github-actions bot added the Type: Feature New feature or request label Jan 18, 2026
@simonostendorf
Copy link
Author

simonostendorf commented Jan 18, 2026

Hey @simonostendorf Sorry that you have needed to wait for so long. Could you rebase your branch and adjust your code to fit our newer standards?

Should be implemented now

deiga
deiga suggested changes Jan 22, 2026
View reviewed changes
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 78de3d9 to fcd48d3 Compare January 22, 2026 22:21
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from fcd48d3 to 07dd337 Compare February 4, 2026 21:18
deiga
deiga suggested changes Feb 9, 2026
View reviewed changes
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from a74c9d4 to d06ac7d Compare February 10, 2026 14:05
deiga
deiga approved these changes Feb 12, 2026
View reviewed changes
@deiga deiga requested a review from stevehipwell February 12, 2026 16:09
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from e18a5af to 90c170d Compare February 12, 2026 16:17
stevehipwell
stevehipwell requested changes Feb 17, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @simonostendorf. I've added some review comments. Could you also add an import method. And ideally the existing SSH key resource should be aligned with this implementation (off the top of my head - migration to add key_id, code changes, and deprecation of url).

@simonostendorf
Copy link
Author

simonostendorf commented Feb 17, 2026

How can I update the website? When I run make website terraform-website downloads and fails because a unknown makefile target is called.

@stevehipwell
Copy link
Collaborator

stevehipwell commented Feb 18, 2026

How can I update the website? When I run make website terraform-website downloads and fails because a unknown makefile target is called.

@simonostendorf you just manually modify the website files, check some previous PRs to see how it was done.

@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from f71b438 to 258ae05 Compare February 18, 2026 19:41
@simonostendorf
Copy link
Author

simonostendorf commented Feb 18, 2026

Everything should be fixed now (hopefully) :D

@stevehipwell
Copy link
Collaborator

stevehipwell commented Feb 23, 2026

@simonostendorf it looks like you've got a conflict, could you please fix this before I give it a review?

@simonostendorf
feat: add github_user_ssh_signing_key
d855d9d 
feat: add docs for github_user_ssh_signing_key

fix: add github_user_ssh_signing_key to provider.go

fix: add github_user_ssh_signing_key to github.erb

fix: use tflog, context, test-structure

fix: use resource-prefix, sweeper, 404-handling, direct read

fix: key_id

feat: import

feat: adjust user_ssh_key to new structure

fix: typo

fix: dont overwrite key on create

fix: add new fields to website
@simonostendorf simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 258ae05 to d855d9d Compare February 23, 2026 20:49
@simonostendorf
Copy link
Author

simonostendorf commented Feb 23, 2026

@simonostendorf it looks like you've got a conflict, could you please fix this before I give it a review?

@stevehipwell fixed :)

@stevehipwell
Copy link
Collaborator

stevehipwell commented Feb 24, 2026

@simonostendorf could you please fix the lint errors.

@simonostendorf
Copy link
Author

simonostendorf commented Feb 24, 2026

@simonostendorf could you please fix the lint errors.

Should be fixed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell Awaiting requested review from stevehipwell

1 more reviewer

@deiga deiga deiga approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

New resource Type: Feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add difference of auth and signing keys to github_user_ssh_key [FEAT]: Support SSH signing keys

6 participants

@simonostendorf @kfcampbell @quotidian-ennui @kilianpaquier @deiga @stevehipwell