Skip to content

Comments

feat: Adding github_enterprise_ip_allow_list_entry resource#2649

Open
ErikElkins wants to merge 30 commits intointegrations:mainfrom
ErikElkins:feat/enterprise-ip-allow-list
Open

feat: Adding github_enterprise_ip_allow_list_entry resource#2649
ErikElkins wants to merge 30 commits intointegrations:mainfrom
ErikElkins:feat/enterprise-ip-allow-list

Conversation

@ErikElkins
Copy link
Contributor

@ErikElkins ErikElkins commented May 2, 2025 •
edited
Loading

Resolves #2648

Before the change?

  • None

After the change?

  • Adding the github_enterprise_ip_allow_list_entry resource.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active May 2, 2025
@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
@ErikElkins ErikElkins changed the title Adding github_enterprise_ip_allow_list_entry resource feat: Adding github_enterprise_ip_allow_list_entry resource Oct 25, 2025
@deiga deiga mentioned this pull request Nov 4, 2025
Open
1 task
@github-actions github-actions bot added the Type: Feature New feature or request label Jan 13, 2026
nickfloyd
nickfloyd previously approved these changes Jan 13, 2026
View reviewed changes
@nickfloyd nickfloyd added this to the v6.10.0 Release milestone Jan 13, 2026
@nickfloyd
Copy link
Member

nickfloyd commented Jan 13, 2026

@ErikElkins Apologies for the delay on getting to this PR. Would you be willing to fix the lint issue? Thank you!

stevehipwell
stevehipwell requested changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a REST API for this functionality?

@github-project-automation github-project-automation bot moved this from 👀 In review to 🏗 In progress in 🧰 Octokit Active Jan 13, 2026
@gateixeira gateixeira mentioned this pull request Jan 13, 2026
Closed
4 tasks
@ErikElkins
Copy link
Contributor Author

ErikElkins commented Jan 13, 2026

Yep! Let me jump in here.

@ErikElkins @stevehipwell
Update github/resource_github_enterprise_ip_allow_list_entry.go
83a0055 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@ErikElkins @stevehipwell
Update github/resource_github_enterprise_ip_allow_list_entry.go
c3735ac 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@ErikElkins
Copy link
Contributor Author

ErikElkins commented Jan 13, 2026 •
edited
Loading

Oh, i see the other PR. Should we just close this? EDIT: NEVERMIND

@ErikElkins
Copy link
Contributor Author

ErikElkins commented Jan 13, 2026

Is there a REST API for this functionality?

Doesn't look like they've added it since I opened the PR.

gateixeira
gateixeira suggested changes Jan 13, 2026
View reviewed changes
Copy link

@gateixeira gateixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ErikElkins 👋

I was updating your PR to have the lint fixed and realized that the acceptance tests seem to also not pass. Can you please update the PR with the following? Feel free to validate on your end.

ErikElkins and others added 3 commits January 13, 2026 14:52
@ErikElkins @gateixeira
Update github/resource_github_enterprise_ip_allow_list_entry.go
833f3f1 
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
@ErikElkins @gateixeira
Update github/resource_github_enterprise_ip_allow_list_entry_test.go
60c686b 
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
@ErikElkins @gateixeira
Update github/resource_github_enterprise_ip_allow_list_entry_test.go
f667dcc 
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
gateixeira
gateixeira approved these changes Jan 13, 2026
View reviewed changes
Copy link

@gateixeira gateixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikElkins thanks for the changes!

ErikElkins and others added 2 commits February 13, 2026 19:33
@ErikElkins @deiga
Update resource_github_enterprise_ip_allow_list_entry.go
d5a1915 
Co-authored-by: Timo Sand <timo.sand@iki.fi>
@ErikElkins @deiga
Update resource_github_enterprise_ip_allow_list_entry.go
2511b0b 
Co-authored-by: Timo Sand <timo.sand@iki.fi>
@deiga deiga requested a review from stevehipwell February 20, 2026 12:32
@deiga
Copy link
Collaborator

deiga commented Feb 20, 2026

@ErikElkins We'll need you to rebase again 😬

@ErikElkins
Copy link
Contributor Author

ErikElkins commented Feb 20, 2026

@ErikElkins We'll need you to rebase again 😬

Done!

stevehipwell
stevehipwell requested changes Feb 20, 2026
View reviewed changes
ErikElkins and others added 3 commits February 20, 2026 08:14
@ErikElkins @stevehipwell
Update github/resource_github_enterprise_ip_allow_list_entry_test.go
d593d56 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@ErikElkins @stevehipwell
Update github/resource_github_enterprise_ip_allow_list_entry.go
10de6a7 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@ErikElkins
Code review changes
4474a4f
stevehipwell
stevehipwell reviewed Feb 20, 2026
View reviewed changes
deiga
deiga suggested changes Feb 20, 2026
View reviewed changes
@deiga deiga requested a review from stevehipwell February 21, 2026 19:10
stevehipwell
stevehipwell requested changes Feb 23, 2026
View reviewed changes
stevehipwell
stevehipwell previously approved these changes Feb 23, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Collaborator

stevehipwell commented Feb 23, 2026

@ErikElkins could you please rebase?

stevehipwell
stevehipwell approved these changes Feb 24, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell stevehipwell approved these changes

@nickfloyd nickfloyd nickfloyd left review comments

+2 more reviewers

@deiga deiga deiga requested changes

@gateixeira gateixeira gateixeira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

github_enterprise New resource Type: Feature New feature or request

Projects

None yet

Milestone

v6.12.0 Release

Development

Successfully merging this pull request may close these issues.

[FEAT]: IP Allow Lists for enterprises and organizations

5 participants

@ErikElkins @nickfloyd @deiga @stevehipwell @gateixeira