Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
I don't have a local golang dev environment so I'll have to wait for the CI build before I can test this locally. |
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left a few comments
| Optional: true, | ||
| Default: nil, | ||
| Description: "The ID of the actor that can bypass a ruleset. When `actor_type` is `OrganizationAdmin`, this should be set to `1`. Some resources such as DeployKey do not have an ID and this should be omitted.", | ||
| Description: "The ID of the actor that can bypass a ruleset. When `actor_type` is `OrganizationAdmin`, this should be set to `1`. When it is `EnterpriseOwner` it should be 0. Some resources such as DeployKey do not have an ID and this should be omitted.", |
There was a problem hiding this comment.
According to the API this should be unset when ORG or Enterprise admin
| } | ||
|
|
||
| bypass_actors { | ||
| actor_id = 0 |
There was a problem hiding this comment.
| actor_id = 0 |
| - `EnterpriseOwner` -> `0` | ||
| - `OrganizationAdmin` -> `1` |
There was a problem hiding this comment.
Please mark these that they shouldn't be set: https://docs.github.com/en/enterprise-cloud@latest/rest/orgs/rules?apiVersion=2022-11-28#create-an-organization-repository-ruleset
|
Thanks for the changes! Have you been able to run the tests locally? |
3 participants
Resolves #3210
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!