Refactor flag names to use constants in benchmark, restore, root, tel… #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emetry, and targets commands Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors flag name constants to improve code consistency and reusability across multiple commands. The changes make flag name constants publicly accessible from the internal/common package, enabling their use in command validation and flag handling throughout the codebase.
Key changes:
- Exported target-related flag name constants in
internal/common/targets.goby capitalizing them (e.g.,flagTargetHostName→FlagTargetHostName) - Added new exported constants for root command flags in
internal/common/common.go(e.g.,FlagDebugName,FlagOutputDirName) - Updated all references across benchmark, restore, root, and telemetry commands to use the new exported constants
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/common/targets.go | Exported target flag name constants and updated all internal references |
| internal/common/common.go | Added new exported constants for root command flags |
| cmd/telemetry/telemetry.go | Simplified flag validation by using Lookup().Changed instead of retrieving flag values |
| cmd/root.go | Removed local flag name constants and updated to use exported constants from common package |
| cmd/config/restore.go | Updated flag name references to use exported constants from common package |
| cmd/benchmark/benchmark.go | Updated flag name references to use exported constants from common package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emetry, and targets commands