Open
Conversation
…using master branch
Intel sync
Adjust field name in hostheartbeat queries
… multiple processes
…ests alongside other project services
…ons for docker compose
Set debug port in docker
Max Profiling Frequency and Profiler Selection in Dynamic Profiling
- Add PostgreSQL schemas for dynamic profiling tables - Add Python Pydantic models for API requests/responses - Add 4 REST API endpoints for dynamic profiling: * POST /api/metrics/profile_request * POST /api/metrics/heartbeat * POST /api/metrics/command_completion * GET /api/metrics/profiling/host_status - Add comprehensive documentation and setup guides - Add unit tests for profiling host status functionality - Includes Slack notification support for profiling events This contribution provides the complete dynamic profiling feature for Intel's gprofiler-performance-studio, enabling start/stop profiling commands, heartbeat monitoring, and host status tracking. Co-authored-by: Pinterest Engineering <engineering@pinterest.com>
Remove files that are specific to Pinterest's infrastructure: - .github/workflows/sync-upstream.yml (Pinterest CI/CD) - DEPLOYMENT_CHECKLIST.md (Pinterest deployment docs) - deploy/localstack_init/01_init_s3_sqs.sh (Pinterest testing) - docs/METRICS_PUBLISHER_INDEXER_DOCUMENTATION.md (Pinterest metrics) - docs/SLI_METRICS_IMPLEMENTATION.md (Pinterest SLI metrics) - src/gprofiler/backend/utils/metrics_publisher.py (Pinterest code) - src/gprofiler_indexer/metrics_publisher.go (Pinterest code) These files are not part of the dynamic profiling contribution to Intel.
- Remove MetricsPublisher import from main.py - Remove startup/shutdown event handlers for MetricsPublisher - Remove all send_sli_metric() calls from profiles_routes.py These are Pinterest-specific metrics tracking not needed for Intel PR.
- Remove MetricsPublisher configuration from args.go - Remove metricsPublisher initialization from main.go - Remove all SendSLIMetric() calls from queue.go and worker.go - Remove related comments These are Pinterest-specific metrics tracking not needed for Intel PR.
- Removed metricsPublisher initialization and cleanup calls from main.go - This completes the cleanup of Pinterest-specific metrics code - Indexer now builds successfully in Docker
- Fixed multiple statements on same line (syntax errors from previous cleanup) - Split logger.error() and raise HTTPException() onto separate lines - Fixed indentation after except blocks - All services now build and run successfully
- Remove hardcoded AWS config and LocalStack from deploy/.env - Remove LocalStack service from deploy/docker-compose.yml - Remove exposed PostgreSQL port from docker-compose.yml - Add database migrations (up/down) for dynamic profiling
Dynamic profiling intel sync
…ntil agent implementation catches up with this feature
- Fix import sorting and formatting in ProfilingStatusPage.jsx - Fix import sorting and formatting in ProfilingTopPanel.jsx - Fix formatting in ProfilingHeader.jsx - Fix long line formatting in iconsData.js
| listen 80; | ||
| server_name your_domain.com www.your_domain.com; # Replace with your domain | ||
|
|
||
| location /api/v2/profiles { |
Contributor
There was a problem hiding this comment.
only to help with local set up
prashantbytesyntax
approved these changes
Mar 5, 2026
Contributor
prashantbytesyntax
left a comment
prashantbytesyntax
left a comment
There was a problem hiding this comment.
approved to unblock for upcoming changes to wall time, perf metrics based flamegraph and command completion api fallback to heartbeat request
Contributor
|
@prashantbytesyntax, @ashokbytebytego, @artursarlo, I don't see adhoc related view option in the following files. Is that the reason I am not able to see the adhoc view icon? src/gprofiler/frontend/src/utils/consts.js (lines 85-90) And do I need any db schema update for adhoc data view? |
Add Ad Hoc Flamegraph Upload and Visualization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Dynamic Profiling Data Models and PostgreSQL Schemas
Summary
This PR contributes the foundational data model infrastructure for the dynamic profiling feature, including PostgreSQL database schemas and Python API models.
What's Included
Database Schema (
scripts/setup/postgres/)API Models (
src/gprofiler/backend/models/)Documentation (
docs/)Tests (
src/tests/)Benefits