[SYCL] Remove unused _PreviewBreakingChanges param from wrapSYCLBinaries#22663
[SYCL] Remove unused _PreviewBreakingChanges param from wrapSYCLBinaries#22663bviyer wants to merge 3 commits into
Conversation
…inaries The change removes the _PreviewBreakingChanges bool parameter (and the file-scoped PreviewBreakingChanges static) from wrapSYCLBinaries and its sole caller. The value was stored but never read.
bviyer
changed the title
|
|
||
| if (Error E = offloading::wrapSYCLBinaries( | ||
| M, Images, offloading::SYCLWrappingOptions(), | ||
| Args.hasArg(OPT_preview_breaking_changes))) |
There was a problem hiding this comment.
should we remove the opt from clang-linker-wrapper too?
There was a problem hiding this comment.
maybe it is good to keep it, in case, we again will introduce breaking changes in the future.
There was a problem hiding this comment.
i dont have a stong opinion but usually i tend to favor removing code that isn't doing anything, i'll leave it up to Balaji.
There was a problem hiding this comment.
+1 for removing unused option.
|
@intel/llvm-gatekeepers please consider merging |
Hi @bviyer, |
I fixed it. |
6 participants
Remove unused _PreviewBreakingChanges parameter from wrapSYCLBinaries
The change removes the _PreviewBreakingChanges bool parameter (and the file-scoped PreviewBreakingChanges static) from wrapSYCLBinaries and its sole caller. The value was stored but never read.