Skip to content

chore(make): hide nextest and cargo progress bars in gate targets - #4733

Merged
panghy merged 1 commit into
mainfrom
gate-test
Sep 11, 2026
Merged

chore(make): hide nextest and cargo progress bars in gate targets#4733
panghy merged 1 commit into
mainfrom
gate-test

Conversation

@panghy

@panghy panghy commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Why

Agents run the Rust gates as saved command-mode ws.script entries, which are PTY-backed. nextest and cargo therefore see an interactive stderr and redraw their progress bars into the captured buffer. One full intent-acp + intent-services run produced ~530 KB of ESC[10A / ESC[2K / ESC[1B cursor-control sequences around a few useful lines; the hook wake built from that buffer overflowed an agent's context (413) and cost a re-delegation.

make test-intentd already pipes nextest's stdout through scripts/resumable_nextest.py, so the noise is entirely on stderr (nextest progress bar + cargo build progress) — environment variables fix both without touching the Python wrapper.

What

  • Makefile: target-specific export NEXTEST_SHOW_PROGRESS ?= none on gate test test-intentd coverage-e2e coverage-all and export CARGO_TERM_PROGRESS_WHEN ?= never on those plus check clippy build-intentd. ?= keeps env / command-line overrides working (make test NEXTEST_SHOW_PROGRESS=bar restores the bar for a human at a terminal). NEXTEST_HIDE_PROGRESS_BAR is deprecated on the pinned nextest 0.9.143, hence NEXTEST_SHOW_PROGRESS.
  • AGENTS.md (Resuming local Rust gates): compress the saved-script bullet to name the PTY hazard and the two flags, pointing at the make targets.

CI already sets CI=true, under which both tools are non-interactive; CI output is unchanged.

Companion docs PR on intentd: intent-hq/intentd — "docs(agents): lead the Gates section with make targets and the PTY progress-bar caveat" (link in the PR conversation once opened).

Verification

  • make -n gate test coverage-all check parse; make -p shows the target-specific bindings; make -n test-intentd NEXTEST_SHOW_PROGRESS=bar reports the command-line value winning.
  • make test-intentd as a PTY-backed saved script: cursor-sequence count in ws.script.output is 0 (evidence in the workspace spec).
  • make docs-check passes.

Saved command-mode ws.script entries are PTY-backed, so nextest and cargo
redraw their progress bars into the captured buffer (one full-suite run
produced ~530 KB of cursor-control sequences and overflowed an agent's
context). Export NEXTEST_SHOW_PROGRESS=none and CARGO_TERM_PROGRESS_WHEN=never
on the Rust gate targets, overridable from the environment or command line,
and point the AGENTS.md gate guidance at the make targets.

Agent-Id: agent-be1f9de1-55b4-4320-a704-77cd94a365ed
@panghy

panghy commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Companion intentd docs PR: intent-hq/intentd#1795

@augmentcode

augmentcode Bot commented Sep 11, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR suppresses interactive Cargo and nextest progress rendering for Make-based Rust gates run through PTY-backed saved scripts.

Changes: It adds overrideable target-scoped environment defaults in the Makefile and documents the PTY output-buffer hazard and equivalent raw-command flags in AGENTS.md.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Code Review Agent🐛

Review completed with 0 suggestions.

Reviewed commit: d0d6916

@panghy
panghy added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 4ef4cdf Sep 11, 2026
7 checks passed
@panghy
panghy deleted the gate-test branch September 11, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant