fix: the site workflow finds the site verb under grouped help - #720
Merged
Merged
Conversation
Since the grouped root help (#711) `abcd --help` names only the person's verbs, and `site` is listed under `abcd --help --agent` alone. site.yml's four probing steps grepped the plain listing, so every site run on a binary built after a3cdf26 refused with "this binary has no site verb": the preview on every push to main, and the production render the release chain calls after publishing v0.11.0. Each probe now reads `--help --agent` and falls back to `--help` when the flag is refused, which is how every tag before v0.11.0 answers it (exit 2, nothing on stdout) while listing all its verbs in the plain help. A binary from before the site slice passes neither and still refuses in one line. The listing is captured in a variable rather than piped, so neither the fallback's non-zero exit nor grep's early exit meets pipefail. Checked against binaries built from v0.6.1 (refused), v0.10.0 and v0.11.0 (found). TestSiteWorkflowProbeFindsTheSiteVerb executes each probing step's own run: script against a stand-in binary answering with the real command tree's help, for four binaries: grouped with the verb, flat with the verb and no --agent, neither, and grouped with the verb withdrawn. It captures the defect in this commit too. No other workflow or script greps a help listing for a verb, and the scaffold templates carry no such probe. Refs: iss-2609260709386741 Assisted-by: Claude:claude-opus-5-5
Resolves: iss-2609260709386741 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the site workflow finds the
siteverb again, so abcdev.app deploys: the preview on every push to main, and the production render for a release.abcd --helplists only the human-facing verbs, andsiteappears underabcd --help --agent. The workflow probed the plain listing, so every site run since then refused with "this binary has no site verb": every preview on main, and v0.11.0's production render after it was published.--agentand still listssitein its plain help, so an emergency redeploy of an older tag keeps working; a binary with no site verb still refuses in one line.TestSiteWorkflowProbeFindsTheSiteVerbruns each probing step's own script out of the committed workflow against the real command tree's help, a flat pre-grouping listing, a pre-site binary and one withsiteremoved.After this merges, the v0.11.0 site is redeployed from main through the workflow's documented emergency path.
Review: Fable 5.1 (review-siteprobe).
Resolves: iss-2609260709386741
Assisted-by: Claude:claude-opus-5-5