feat: modified for usage with esp-idf, where multiple extra files are… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needed, removed hex default req
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… needed, removed hex default req
This change was needed for a ESP-IDF project. There are no hex file outputs by default. And to be useful for ESP-IDF, we need to include more bin files as extra files.
Either I'm using it wrong (highly possible, thanks cmake) or the extra files doesn't accept a list of files. So I added it here.
Taking a step back, the format of required files here is somewhat oriented to a zephyr based project, or something highly custom via cmake. Is it possible we could construct a predefined set of outputs we want for our project instead? I think that may break the simplicity of how I interpret this project's goals.
The breaking change here is that other projects which already provide a hex file would lose it in the bundling, and requires it to be added individually.