Cleanup serial data handling #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! This should resolve #12, take a look for details. I hope it's possible to avoid creating tasks and rely on queues instead. Callback could be useful for flexibility, but I suspect that the average use case would be to await the device log "channel" - the queue. The refactor does appear to simplify the code, nice work! |
Collaborator
|
Type ignores can be OK for mocking and monkey patching in the tests. |
JaagupAverin
force-pushed
the
main
branch
3 times, most recently
from
0737650 to
f1108df
Compare
Contributor
Author
|
I think a lot of use cases are going to need a separate task for handling the serial data anyways so I wanted to hide it underneath the library. But I understand you'd rather not have this complexity. Made quick force push with new implementation. |
Makes the buffer processing hopefully a bit more clear. Non-SMP data is no longer logged to stdout but can be accessed with the read_serial() function.
Previously the packet read timeout wasn't actually used, as it was passed to Serial, but serial was read with .read_all(), which does not respect any timeouts. Rename, reformat and clean up some code from the previous commit.
Single bytes cannot be flushed to serial if they may be starts of SMP packets. Technically this introduces an edge case where 0x04 or 0x06 is the very last character of a valid serial data stream, and will then not get flushed properly, but the chances of that are very small, and there aren't any good workarounds to this.
JaagupAverin
force-pushed
the
main
branch
2 times, most recently
from
835d6af to
634f5ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Cleanup non-smp serial data handling.
Makes the buffer processing hopefully a bit more clear. Non-SMP data is no longer logged to stdout but can be accessed with the read_serial() function.