Skip to content

[PB-5649]: Add automatic trash disposal notification dialog#1798

Merged
terrerox merged 16 commits intomasterfrom
feature/automatic-trash-disposal
Feb 26, 2026
Merged

[PB-5649]: Add automatic trash disposal notification dialog#1798
terrerox merged 16 commits intomasterfrom
feature/automatic-trash-disposal

Conversation

@terrerox
Copy link
Contributor

@terrerox terrerox commented Jan 6, 2026

Description

Implement an informational modal that notifies users about the new automatic trash disposal
feature. The dialog displays tier-based retention periods (1 day for free users, 7 days for
essential, 14 days for premium, and 30 days for ultimate users).

  • Create AutomaticTrashDisposalDialog component with responsive dark mode styling
  • Add UI state management for dialog visibility
  • Display modal only to existing users (excludes new signups)
  • Add translation keys for dialog content
  • Integrate dialog into Trash view with proper state handling

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2026

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38b41a6
Status: ✅  Deploy successful!
Preview URL: https://2a83792f.drive-web.pages.dev
Branch Preview URL: https://feature-automatic-trash-disp.drive-web.pages.dev

View logs

@terrerox terrerox self-assigned this Jan 7, 2026
import { userSelectors } from 'app/store/slices/user';
import localStorageService from 'services/local-storage.service';

const HAS_SEEN_TRASH_DISPOSAL_DIALOG_KEY = 'hasSeenTrashDisposalDialog';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add the key with the rest of local storage ones

@terrerox terrerox requested a review from CandelR January 9, 2026 04:28
  Implement an informational modal that notifies users about the new automatic trash disposal
  feature. The dialog displays tier-based retention periods (1 day for free users, 7 days for
  essential, 14 days for premium, and 30 days for ultimate users).

  - Create AutomaticTrashDisposalDialog component with responsive dark mode styling
  - Add UI state management for dialog visibility
  - Display modal only to existing users (excludes new signups)
  - Add translation keys for dialog content
  - Integrate dialog into Trash view with proper state handling
  Add a new "Auto-delete" column in the trash list that displays the number of days until an item is
  permanently deleted. The column shows "In X day(s)" with a warning icon, and highlights items in red when
  they have 2 days or less remaining.

  Changes:
  - Add caducityDate field to DriveFileData and DriveFolderData types
  - Add "Auto-delete" translation key to English locale
  - Create skinSkeletonTrash for trash view loading state
  - Add auto-delete column header to trash list (non-orderable)
  - Display auto-delete countdown with WarningCircle icon in list items
  - Calculate days until deletion from caducityDate field
  - Apply red text styling for urgent items (≤2 days remaining)
@terrerox terrerox force-pushed the feature/automatic-trash-disposal branch from e798fff to e1e23a7 Compare February 26, 2026 13:52
@sonarqubecloud
Copy link

@terrerox terrerox merged commit 15d9601 into master Feb 26, 2026
9 of 10 checks passed
@terrerox terrerox deleted the feature/automatic-trash-disposal branch February 26, 2026 15:33
terrerox added a commit that referenced this pull request Feb 26, 2026
…h-disposal"

This reverts commit 15d9601, reversing
changes made to dec66cc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants