fix: include symbol_id in search results - #45
Open
pradeepmouli wants to merge 1 commit into
Open
Conversation
tool_search, tool_search_symbols (MCP), and cmd_search (CLI) all correlate results back to a row keyed by symbol_id internally, but never printed it in the output -- breaking the ability to chain a search result directly into trace_callers/get_code_snippet/ symbol_context/transitive_impact without a separate lookup call. Closes #23.
pradeepmouli
requested review from
johnintuit,
murari316 and
sandeep-mewara
as code owners
July 30, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_search,tool_search_symbols(MCP), andcmd_search(CLI) all correlate results back to a row keyed bysymbol_idinternally, but never printed it in the output. That breaks the ability to chain a search result directly intotrace_callers/get_code_snippet/symbol_context/transitive_impact— callers have to fall back toget_symbols_in_file(which does printid=) just to get an ID usable with those tools.Change
Appends
id=<symbol_id>to each result line in all three functions, matchingget_symbols_in_file's existing convention.Test plan
cargo build -p infigraph-mcp -p infigraph-cli— cleancargo test -p infigraph-mcp --test tool_dispatch— passcargo test -p infigraph-cli— pass (includescli_parity)infigraph searchand the MCPsearch/search_symbolstools now includeid=in output