Conversation
forgot to do that after converting to modular, so it was returning an internal error, it works in testing (using rnfbdemo/make-demo.sh) with this fix deployed also made sure to deploy in correct project by adding a `firebase use` command to the functions deploy package.json script
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
russellwheatley
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the kotlin documentation for this platform API, the return value is designated as nullable, but in the android documentation it is not
Java not noted as null: https://developer.android.com/reference/kotlin/android/app/TaskInfo#baseactivity
Kotlin indeed is ? return: https://developer.android.com/reference/kotlin/android/app/TaskInfo#baseactivity
We coded off the android API and expected it to be non-null but there are user reports of a crash here
So, make the access to this potentially null method result null-safe and return a reasonable default in that case
Related issues
Release Summary
fix release via conventional commit
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Only way to cover it via tests is to receive a local FCM in foreground and background, I exercised that with my build demo which has that feature -- the code is exercised upon receipt of any FCM - while using locally created packages from this PR
https://github.com/mikehardy/rnfbdemo/blob/4ff72ba5b9894542e838b246562c9c14d285aef4/App.tsx#L276-L289
I had to fixup the test cloud function though, as it wasn't working since I converted to v2 / modular functions API and I haven't exercised it yet to notice! It works now though.
Testing indicated that the code path was definitely hit, as I received the test FCM, and the
RNFirebaseMsgReceivermessage indicates the code path was traveled since there is no possible way through the code without hitting that method, if you see this log message but not the one saying "broadcast intent received with no extras"ref:
react-native-firebase/packages/messaging/android/src/main/java/io/invertase/firebase/messaging/ReactNativeFirebaseMessagingReceiver.java
Lines 21 to 43 in 9fb5ab5
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter