-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ci(docs): add docs.page link check to docs workflow #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ npmMinimalAgeGate: 7d | |
| # In case you must have a package version that would be disallowed | ||
| # by the above npmMinimalAgeGate | ||
| npmPreapprovedPackages: | ||
| - '@docs.page/cli@2.1.0' # published 2026-09-04; needed immediately for docs CI | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reference.rnfirebase.io gap is still there. 2.1.0 treats 401/403/405/429 as warnings on every host, and nothing here pins reference.rnfirebase.io back to hard-error. That host isn't bot-gated today, but if Cloudflare/Fastly ever 429s it under the burst of requests this check fires, a real broken TypeDoc link would quietly become a warning instead of failing the build, which is the whole thing this PR is meant to catch.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good one and it's handled poorly - I've pursuing upstream CLI remediation/features that will stop conflating "bot blocked" vs "failed but should have worked" so we don't downgrade things we want. Upstream pursuit:
This whole PR should sit again until those are resolved - this exercise is making the docs.page CLI checker a lot more battle-tested that's for sure! |
||
| - '@firebase/ai@2.14.0' | ||
| - '@firebase/analytics-compat@0.2.29' | ||
| - '@firebase/analytics-types@0.8.4' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is already flaky on this exact commit. Same head SHA, two runs: one failed on invertase.io/blog/... with "operation was aborted" (timeout), the other passed clean with 0 errors. I hit that blog URL directly a few times just now and it's fine, so this looks like a transient network hiccup, not a real 404, and there's no retry around it (Yarn Install a few lines up already wraps itself in nick-fields/retry). As-is this will occasionally fail PRs for no reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment above should work to handle this