fix(crashlytics, ios): resolve target-folder GoogleService-Info.plist for SPM dSYM upload - #9305
Open
russellwheatley wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9305 +/- ##
=========================================
Coverage 69.49% 69.49%
Complexity 2129 2129
=========================================
Files 439 439
Lines 25472 25472
Branches 4251 4251
=========================================
Hits 17700 17700
Misses 6365 6365
Partials 1407 1407
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
… for SPM dSYM upload
ios_config.sh hardcoded ${PROJECT_DIR}/GoogleService-Info.plist for the SPM
upload-symbols branches. Both Expo's config plugin and RNFB's documented
manual/CLI setup place the plist at ios/<TargetName>/GoogleService-Info.plist
instead, so any SPM Crashlytics setup following those docs failed the dSYM
upload build phase.
Resolve the plist path once (target-folder first, falling back to the
PROJECT_DIR root), reuse it in both upload-symbols invocations, and warn and
skip the upload instead of hard-failing when neither location has it.
Fixes #9304
russellwheatley
force-pushed
the
feature/cprn-439-9304-iosspmcrashlytics-dsym-upload-symbols-hardcodes
branch
from
September 9, 2026 14:40
e9b4b4c to
7be1cc1
Compare
russellwheatley
marked this pull request as ready for review
September 10, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPM
upload-symbolsbranches inios_config.shhardcoded${PROJECT_DIR}/GoogleService-Info.plist. Both Expo's config plugin and RNFB's documented manual/CLI setup place the plist atios/<TargetName>/GoogleService-Info.plistinstead, so any SPM Crashlytics setup following those docs failed the dSYM upload build phase. CocoaPods setups were unaffected sinceupload-symbolsthere resolves the plist from inside the Pods sandbox.PROJECT_DIRrootupload-symbolsinvocations instead of duplicating the checkpackages/crashlytics/__tests__/ios_config.test.ts, running the script against a stubbedupload-symbolsbinary in a temp sandbox, covering the target-folder path, the root fallback, and the neither-found warn-and-skip caseMaintainer note: Fixes internal CPRN-439