Fix graph stall for collectors downstream of empty iterators#9349
Open
JPPhoto wants to merge 3 commits into
Open
Fix graph stall for collectors downstream of empty iterators#9349JPPhoto wants to merge 3 commits into
JPPhoto wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes graph execution stalling when a
Collectnode is downstream of an iterator over an empty collection.Zero-iteration expansions are now explicitly recorded as complete. This allows downstream collectors to execute with an empty collection, typed consumers to receive
[], and the session to report completion.Collector output validation now handles materialized collectors with no runtime input edges. In this case, the already-validated source graph remains authoritative for type compatibility.
Related Issues / Discussions
Closes #9347
QA Instructions
Added coverage for:
IntegerCollection([]) -> Iterate -> Add -> Collect -> typed consumerIterate -> Collect -> Iterate -> Collectchains[]GraphExecutionState.is_complete()returningTrueMerge Plan
Checklist
What's Newcopy (if doing a release after this PR)