Centralize FusionInterrupt handling in embedding layer#521
Merged
toddjonker merged 3 commits intoion-fusion:mainfrom Apr 14, 2026
Merged
Conversation
DimitriosDalaklidhs
requested review from
SharkBaitDLS and
toddjonker
as code owners
Member
|
@DimitriosDalaklidhs Can you please do a (non-merge) rebase and force-push a single commit with the relevant change? This is currently on a lengthy fork of the upstream mainline. The main impact is that when I merge the change I have to filter through all the previously-applied and intermediate commit logs. |
toddjonker
reviewed
Apr 13, 2026
DimitriosDalaklidhs
force-pushed
the
feature/isolate-interrupt-handling-517
branch
from
aeb1ae9 to
922ab50
Compare
toddjonker
approved these changes
Apr 14, 2026
Member
toddjonker
left a comment
toddjonker
left a comment
There was a problem hiding this comment.
I made some small formatting changes, and this is good to go.
Member
|
Oh weird, looks like GitHub is requiring a non-me reviewer since I committed a change to the PR. So this is back at you @SharkBaitDLS |
SharkBaitDLS
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517
Introduces
EvalTask<T>functional interface andwithEvaluator()helperon
StandardTopLevelto centralizeFusionInterrupt → FusionInterruptedExceptiontranslation in one place.
All call sites in
StandardTopLevelandStandardRuntimenow usewithEvaluator(), including the previously missingionizeandionizeMaybemethods inStandardRuntime.