Make top-level forward references more robust.#523
Merged
toddjonker merged 1 commit intoion-fusion:mainfrom Apr 15, 2026
Merged
Make top-level forward references more robust.#523toddjonker merged 1 commit intoion-fusion:mainfrom
toddjonker merged 1 commit intoion-fusion:mainfrom
Conversation
In conjunction with recent locking of storage in `Namespace`, this addresses a race condition to ensure the result is always valid. The code is heavily rearranged and more thoroughly explained. The new test case is less useful than it appears: the non-atomicity of `define` is deeper in the implementation than we can meaningfully test. I had written most of this before I realized that, but the breakpoint approach seems worth keeping, so here it is.
SharkBaitDLS
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In conjunction with recent locking of storage in
Namespace, this addresses a race condition to ensure the result is always valid.The code is heavily rearranged and more thoroughly explained.
The new test case is less useful than it appears: the non-atomicity of
defineis deeper in the implementation than we can meaningfully test. I had written most of this before I realized that, but the breakpoint approach seems worth keeping, so here it is.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.