feat(cli): add experimental packageOptions#8471
Merged
Merged
Conversation
OS-pedrogustavobilro
approved these changes
May 26, 2026
Contributor
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Tested with your app and a few others, everything's working well, very nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition of the folder name conflict, I found another conflict with target names, so for the folder name problem I added
symlinkoption, which will create a symbolic link to the node_modules folder inside a newsymlinksfolder (so we can remove it on update to remove old symbolic links before doing the copy and configuration of existing plugins), since we don't keep track of existing plugins, it's better to just remove everything and start over to not have dangling symlinks after plugin removals.For target name conflicts I added
moduleAliases, where you put the existing target name, and the name to be used as aliascan be tested on https://github.com/jcesarmobile/devicecollision which has both
@capacitor/deviceand@capacitor-community/deviceand when you fix the folder name problem withsymlink: true, the target name problem appears. Adding this to solve both problems:closes #8451
We should probably put the packageTraits inside packageOptions, but didn't do it since it would be breaking, we could do it for Capacitor 9, unless we update to Swift 6 and we could make them non experimental.